Skip to content

GitLab

T
tangled
Commit 008bfa60 authored by aroben@apple.com's avatar aroben@apple.com
Browse files
Options

Tell Trac logs always to display all specified revisions in a single page 

Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.

Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
Updated tests for the above.

git-svn-id: svn://svn.chromium.org/blink/trunk@93224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 93e3401b
Hide whitespace changes
Inline Side-by-side
Showing with 31 additions and 8 deletions
third_party/WebKit/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js
View file @ 008bfa60
......@@ -77,7 +77,7 @@ const testCases = [
failingTests: [
'css1/basic/class_as_selector.html',
],
expectedDescription: 'css1/basic/class_as_selector.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedDescription: 'css1/basic/class_as_selector.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): css1/basic/class_as_selector.html failing on Windows 7 Release (Tests)',
},
{
......@@ -87,7 +87,7 @@ const testCases = [
'css1/basic/class_as_selector.html',
'fast/css/ex-after-font-variant.html',
],
expectedDescription: 'css1/basic/class_as_selector.html and fast/css/ex-after-font-variant.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedDescription: 'css1/basic/class_as_selector.html and fast/css/ex-after-font-variant.html started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive).\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): css1/basic/class_as_selector.html, fast/css/ex-after-font-variant.html failing on Windows 7 Release (Tests)',
},
{
......@@ -103,7 +103,7 @@ const testCases = [
'css1/basic/class_as_selector7.html',
'css1/basic/class_as_selector8.html',
],
expectedDescription: 'The following tests started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive):\n\n css1/basic/class_as_selector1.html\n css1/basic/class_as_selector2.html\n css1/basic/class_as_selector3.html\n css1/basic/class_as_selector4.html\n css1/basic/class_as_selector5.html\n css1/basic/class_as_selector6.html\n css1/basic/class_as_selector7.html\n css1/basic/class_as_selector8.html\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedDescription: 'The following tests started failing on Windows 7 Release (Tests) between r9 and r10 (inclusive):\n\n css1/basic/class_as_selector1.html\n css1/basic/class_as_selector2.html\n css1/basic/class_as_selector3.html\n css1/basic/class_as_selector4.html\n css1/basic/class_as_selector5.html\n css1/basic/class_as_selector6.html\n css1/basic/class_as_selector7.html\n css1/basic/class_as_selector8.html\n\nhttp://trac.webkit.org/log/trunk?rev=10&stop_rev=9&limit=3\n\n[RESULTS PAGE URL Windows 7 Release (Tests), r8 (2)] passed\n[RESULTS PAGE URL Windows 7 Release (Tests), r10 (5)] failed\n',
expectedTitle: 'REGRESSION (r8-r10): 8 css1/basic tests failing on Windows 7 Release (Tests)',
},
{
......
third_party/WebKit/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js
View file @ 008bfa60
......@@ -137,6 +137,9 @@ trac.logURL = function(path, startRevision, endRevision, showFullCommitLogs, for
var queryParameters = {
rev: endRevision,
stop_rev: startRevision,
// Trac requires limit to be 1 more than the number of revisions we actually want to show.
// See <http://trac.edgewall.org/ticket/10317>.
limit: endRevision - startRevision + 2,
};
if (showFullCommitLogs)
......
third_party/WebKit/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js
View file @ 008bfa60
......@@ -285,10 +285,10 @@ test("changesetURL", 1, function() {
});
test("logURL", 4, function() {
equals(trac.logURL('trunk', 1234, 1236, false, false), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234");
equals(trac.logURL('trunk', 1234, 1234, true, false), "http://trac.webkit.org/log/trunk?rev=1234&stop_rev=1234&verbose=on");
equals(trac.logURL('trunk', 1236, 1236, false, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1236&format=rss");
equals(trac.logURL('trunk', 1234, 1236, true, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&verbose=on&format=rss");
equals(trac.logURL('trunk', 1234, 1236, false, false), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&limit=4");
equals(trac.logURL('trunk', 1234, 1234, true, false), "http://trac.webkit.org/log/trunk?rev=1234&stop_rev=1234&limit=2&verbose=on");
equals(trac.logURL('trunk', 1236, 1236, false, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1236&limit=2&format=rss");
equals(trac.logURL('trunk', 1234, 1236, true, true), "http://trac.webkit.org/log/trunk?rev=1236&stop_rev=1234&limit=4&verbose=on&format=rss");
});
test("recentCommitData", 3, function() {
......@@ -318,7 +318,7 @@ test("commitDataForRevisionRange", 3, function() {
var simulator = new NetworkSimulator();
simulator.get = function(url, callback)
{
equals(url, 'http://trac.webkit.org/log/trunk?rev=12365&stop_rev=12345&verbose=on&format=rss');
equals(url, 'http://trac.webkit.org/log/trunk?rev=12365&stop_rev=12345&limit=22&verbose=on&format=rss');
simulator.scheduleCallback(function() {
var parser = new DOMParser();
var responseDOM = parser.parseFromString(kExampleCommitDataXML, "application/xml");
......
third_party/WebKit/Tools/ChangeLog
View file @ 008bfa60
2011-08-17 Adam Roben <aroben@apple.com>
Tell Trac logs always to display all specified revisions in a single page
Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
revisions than that.
Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
relevant revisions
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
a single page.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
Updated tests for the above.
2011-08-17 Adam Roben <aroben@apple.com>
Fix TestFailures's link to file a bug about TestFailures itself
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment