Commit 00b3e3e1 authored by Yeol's avatar Yeol Committed by Commit Bot

Replace Platform::Current() with TestingPlatformSupport to call GetURLLoaderMockFactory.

It's modified in core/frame and /platform.

Bug: 751425
Change-Id: Ibe09bbd6debbcfcbef5624f98ec486770d97698c
Reviewed-on: https://chromium-review.googlesource.com/611742Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501581}
parent 34aae082
...@@ -37,9 +37,9 @@ ...@@ -37,9 +37,9 @@
#include "core/frame/WebLocalFrameImpl.h" #include "core/frame/WebLocalFrameImpl.h"
#include "core/geometry/DOMRect.h" #include "core/geometry/DOMRect.h"
#include "core/page/Page.h" #include "core/page/Page.h"
#include "platform/testing/TestingPlatformSupport.h"
#include "platform/testing/URLTestHelpers.h" #include "platform/testing/URLTestHelpers.h"
#include "platform/testing/UnitTestHelpers.h" #include "platform/testing/UnitTestHelpers.h"
#include "public/platform/Platform.h"
#include "public/platform/WebCoalescedInputEvent.h" #include "public/platform/WebCoalescedInputEvent.h"
#include "public/platform/WebURLLoaderMockFactory.h" #include "public/platform/WebURLLoaderMockFactory.h"
#include "public/web/WebElement.h" #include "public/web/WebElement.h"
...@@ -66,8 +66,7 @@ class BrowserControlsTest : public ::testing::Test { ...@@ -66,8 +66,7 @@ class BrowserControlsTest : public ::testing::Test {
} }
~BrowserControlsTest() override { ~BrowserControlsTest() override {
Platform::Current() platform_->GetURLLoaderMockFactory()
->GetURLLoaderMockFactory()
->UnregisterAllURLsAndClearMemoryCache(); ->UnregisterAllURLsAndClearMemoryCache();
} }
...@@ -139,6 +138,7 @@ class BrowserControlsTest : public ::testing::Test { ...@@ -139,6 +138,7 @@ class BrowserControlsTest : public ::testing::Test {
private: private:
std::string base_url_; std::string base_url_;
FrameTestHelpers::WebViewHelper helper_; FrameTestHelpers::WebViewHelper helper_;
ScopedTestingPlatformSupport<TestingPlatformSupport> platform_;
}; };
// Disable these tests on Mac OSX until further investigation. // Disable these tests on Mac OSX until further investigation.
......
...@@ -37,12 +37,12 @@ ...@@ -37,12 +37,12 @@
#include "core/frame/FrameTestHelpers.h" #include "core/frame/FrameTestHelpers.h"
#include "core/frame/WebLocalFrameImpl.h" #include "core/frame/WebLocalFrameImpl.h"
#include "platform/SerializedResource.h" #include "platform/SerializedResource.h"
#include "platform/testing/TestingPlatformSupport.h"
#include "platform/testing/URLTestHelpers.h" #include "platform/testing/URLTestHelpers.h"
#include "platform/testing/UnitTestHelpers.h" #include "platform/testing/UnitTestHelpers.h"
#include "platform/wtf/Assertions.h" #include "platform/wtf/Assertions.h"
#include "platform/wtf/Deque.h" #include "platform/wtf/Deque.h"
#include "platform/wtf/Vector.h" #include "platform/wtf/Vector.h"
#include "public/platform/Platform.h"
#include "public/platform/WebString.h" #include "public/platform/WebString.h"
#include "public/platform/WebThread.h" #include "public/platform/WebThread.h"
#include "public/platform/WebURL.h" #include "public/platform/WebURL.h"
...@@ -68,8 +68,7 @@ class FrameSerializerTest : public ::testing::Test, ...@@ -68,8 +68,7 @@ class FrameSerializerTest : public ::testing::Test,
} }
void TearDown() override { void TearDown() override {
Platform::Current() platform_->GetURLLoaderMockFactory()
->GetURLLoaderMockFactory()
->UnregisterAllURLsAndClearMemoryCache(); ->UnregisterAllURLsAndClearMemoryCache();
} }
...@@ -100,7 +99,7 @@ class FrameSerializerTest : public ::testing::Test, ...@@ -100,7 +99,7 @@ class FrameSerializerTest : public ::testing::Test,
response.SetMIMEType("text/html"); response.SetMIMEType("text/html");
response.SetHTTPStatusCode(status_code); response.SetHTTPStatusCode(status_code);
Platform::Current()->GetURLLoaderMockFactory()->RegisterErrorURL( platform_->GetURLLoaderMockFactory()->RegisterErrorURL(
KURL(base_url_, file), response, error); KURL(base_url_, file), response, error);
} }
...@@ -195,6 +194,7 @@ class FrameSerializerTest : public ::testing::Test, ...@@ -195,6 +194,7 @@ class FrameSerializerTest : public ::testing::Test,
HashMap<String, String> rewrite_urls_; HashMap<String, String> rewrite_urls_;
Vector<String> skip_urls_; Vector<String> skip_urls_;
String rewrite_folder_; String rewrite_folder_;
ScopedTestingPlatformSupport<TestingPlatformSupport> platform_;
}; };
TEST_F(FrameSerializerTest, HTMLElements) { TEST_F(FrameSerializerTest, HTMLElements) {
......
...@@ -43,11 +43,11 @@ ...@@ -43,11 +43,11 @@
#include "platform/SharedBuffer.h" #include "platform/SharedBuffer.h"
#include "platform/mhtml/MHTMLArchive.h" #include "platform/mhtml/MHTMLArchive.h"
#include "platform/mhtml/MHTMLParser.h" #include "platform/mhtml/MHTMLParser.h"
#include "platform/testing/TestingPlatformSupport.h"
#include "platform/testing/URLTestHelpers.h" #include "platform/testing/URLTestHelpers.h"
#include "platform/testing/UnitTestHelpers.h" #include "platform/testing/UnitTestHelpers.h"
#include "platform/weborigin/KURL.h" #include "platform/weborigin/KURL.h"
#include "platform/weborigin/SchemeRegistry.h" #include "platform/weborigin/SchemeRegistry.h"
#include "public/platform/Platform.h"
#include "public/platform/WebString.h" #include "public/platform/WebString.h"
#include "public/platform/WebURL.h" #include "public/platform/WebURL.h"
#include "public/platform/WebURLLoaderMockFactory.h" #include "public/platform/WebURLLoaderMockFactory.h"
...@@ -95,8 +95,7 @@ class MHTMLTest : public ::testing::Test { ...@@ -95,8 +95,7 @@ class MHTMLTest : public ::testing::Test {
void SetUp() override { helper_.Initialize(); } void SetUp() override { helper_.Initialize(); }
void TearDown() override { void TearDown() override {
Platform::Current() platform_->GetURLLoaderMockFactory()
->GetURLLoaderMockFactory()
->UnregisterAllURLsAndClearMemoryCache(); ->UnregisterAllURLsAndClearMemoryCache();
} }
...@@ -195,6 +194,7 @@ class MHTMLTest : public ::testing::Test { ...@@ -195,6 +194,7 @@ class MHTMLTest : public ::testing::Test {
String file_path_; String file_path_;
Vector<SerializedResource> resources_; Vector<SerializedResource> resources_;
FrameTestHelpers::WebViewHelper helper_; FrameTestHelpers::WebViewHelper helper_;
ScopedTestingPlatformSupport<TestingPlatformSupport> platform_;
}; };
// Checks that the domain is set to the actual MHTML file, not the URL it was // Checks that the domain is set to the actual MHTML file, not the URL it was
......
...@@ -139,7 +139,7 @@ TEST_F(ResourceFetcherTest, UseExistingResource) { ...@@ -139,7 +139,7 @@ TEST_F(ResourceFetcherTest, UseExistingResource) {
FetchParameters fetch_params{ResourceRequest(url)}; FetchParameters fetch_params{ResourceRequest(url)};
Resource* resource = MockResource::Fetch(fetch_params, fetcher); Resource* resource = MockResource::Fetch(fetch_params, fetcher);
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
EXPECT_TRUE(resource->IsLoaded()); EXPECT_TRUE(resource->IsLoaded());
EXPECT_TRUE(GetMemoryCache()->Contains(resource)); EXPECT_TRUE(GetMemoryCache()->Contains(resource));
...@@ -164,8 +164,7 @@ TEST_F(ResourceFetcherTest, Vary) { ...@@ -164,8 +164,7 @@ TEST_F(ResourceFetcherTest, Vary) {
ResourceRequest resource_request(url); ResourceRequest resource_request(url);
resource_request.SetRequestContext(WebURLRequest::kRequestContextInternal); resource_request.SetRequestContext(WebURLRequest::kRequestContextInternal);
FetchParameters fetch_params(resource_request); FetchParameters fetch_params(resource_request);
Platform::Current()->GetURLLoaderMockFactory()->RegisterURL( platform_->GetURLLoaderMockFactory()->RegisterURL(url, WebURLResponse(), "");
url, WebURLResponse(), "");
Resource* new_resource = RawResource::Fetch(fetch_params, fetcher); Resource* new_resource = RawResource::Fetch(fetch_params, fetcher);
EXPECT_NE(resource, new_resource); EXPECT_NE(resource, new_resource);
new_resource->Loader()->Cancel(); new_resource->Loader()->Cancel();
...@@ -182,8 +181,7 @@ TEST_F(ResourceFetcherTest, NavigationTimingInfo) { ...@@ -182,8 +181,7 @@ TEST_F(ResourceFetcherTest, NavigationTimingInfo) {
resource_request.SetFrameType(WebURLRequest::kFrameTypeNested); resource_request.SetFrameType(WebURLRequest::kFrameTypeNested);
resource_request.SetRequestContext(WebURLRequest::kRequestContextForm); resource_request.SetRequestContext(WebURLRequest::kRequestContextForm);
FetchParameters fetch_params(resource_request); FetchParameters fetch_params(resource_request);
Platform::Current()->GetURLLoaderMockFactory()->RegisterURL( platform_->GetURLLoaderMockFactory()->RegisterURL(url, WebURLResponse(), "");
url, WebURLResponse(), "");
Resource* resource = Resource* resource =
RawResource::FetchMainResource(fetch_params, fetcher, SubstituteData()); RawResource::FetchMainResource(fetch_params, fetcher, SubstituteData());
resource->ResponseReceived(response, nullptr); resource->ResponseReceived(response, nullptr);
...@@ -246,7 +244,7 @@ TEST_F(ResourceFetcherTest, VaryResource) { ...@@ -246,7 +244,7 @@ TEST_F(ResourceFetcherTest, VaryResource) {
FetchParameters fetch_params_original{ResourceRequest(url)}; FetchParameters fetch_params_original{ResourceRequest(url)};
Resource* resource = MockResource::Fetch(fetch_params_original, fetcher); Resource* resource = MockResource::Fetch(fetch_params_original, fetcher);
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
ASSERT_TRUE(resource->MustReloadDueToVaryHeader(ResourceRequest(url))); ASSERT_TRUE(resource->MustReloadDueToVaryHeader(ResourceRequest(url)));
FetchParameters fetch_params{ResourceRequest(url)}; FetchParameters fetch_params{ResourceRequest(url)};
...@@ -305,7 +303,7 @@ TEST_F(ResourceFetcherTest, RevalidateWhileFinishingLoading) { ...@@ -305,7 +303,7 @@ TEST_F(ResourceFetcherTest, RevalidateWhileFinishingLoading) {
Persistent<RequestSameResourceOnComplete> client = Persistent<RequestSameResourceOnComplete> client =
new RequestSameResourceOnComplete(resource1); new RequestSameResourceOnComplete(resource1);
resource1->AddClient(client); resource1->AddClient(client);
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
EXPECT_TRUE(client->NotifyFinishedCalled()); EXPECT_TRUE(client->NotifyFinishedCalled());
resource1->RemoveClient(client); resource1->RemoveClient(client);
} }
...@@ -489,7 +487,7 @@ TEST_F(ResourceFetcherTest, PreloadResourceTwice) { ...@@ -489,7 +487,7 @@ TEST_F(ResourceFetcherTest, PreloadResourceTwice) {
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
EXPECT_TRUE(resource->IsLinkPreload()); EXPECT_TRUE(resource->IsLinkPreload());
EXPECT_TRUE(fetcher->ContainsAsPreload(resource)); EXPECT_TRUE(fetcher->ContainsAsPreload(resource));
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
FetchParameters fetch_params{ResourceRequest(url)}; FetchParameters fetch_params{ResourceRequest(url)};
fetch_params.SetLinkPreload(true); fetch_params.SetLinkPreload(true);
...@@ -515,7 +513,7 @@ TEST_F(ResourceFetcherTest, LinkPreloadResourceAndUse) { ...@@ -515,7 +513,7 @@ TEST_F(ResourceFetcherTest, LinkPreloadResourceAndUse) {
Resource* resource = MockResource::Fetch(fetch_params_original, fetcher); Resource* resource = MockResource::Fetch(fetch_params_original, fetcher);
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
EXPECT_TRUE(resource->IsLinkPreload()); EXPECT_TRUE(resource->IsLinkPreload());
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
// Resource created by preload scanner // Resource created by preload scanner
FetchParameters fetch_params_preload_scanner{ResourceRequest(url)}; FetchParameters fetch_params_preload_scanner{ResourceRequest(url)};
...@@ -547,7 +545,7 @@ TEST_F(ResourceFetcherTest, PreloadMatchWithBypassingCache) { ...@@ -547,7 +545,7 @@ TEST_F(ResourceFetcherTest, PreloadMatchWithBypassingCache) {
Resource* resource = MockResource::Fetch(fetch_params_original, fetcher); Resource* resource = MockResource::Fetch(fetch_params_original, fetcher);
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
EXPECT_TRUE(resource->IsLinkPreload()); EXPECT_TRUE(resource->IsLinkPreload());
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
FetchParameters fetch_params_second{ResourceRequest(url)}; FetchParameters fetch_params_second{ResourceRequest(url)};
fetch_params_second.MutableResourceRequest().SetCachePolicy( fetch_params_second.MutableResourceRequest().SetCachePolicy(
...@@ -569,7 +567,7 @@ TEST_F(ResourceFetcherTest, CrossFramePreloadMatchIsNotAllowed) { ...@@ -569,7 +567,7 @@ TEST_F(ResourceFetcherTest, CrossFramePreloadMatchIsNotAllowed) {
Resource* resource = MockResource::Fetch(fetch_params_original, fetcher); Resource* resource = MockResource::Fetch(fetch_params_original, fetcher);
ASSERT_TRUE(resource); ASSERT_TRUE(resource);
EXPECT_TRUE(resource->IsLinkPreload()); EXPECT_TRUE(resource->IsLinkPreload());
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
FetchParameters fetch_params_second{ResourceRequest(url)}; FetchParameters fetch_params_second{ResourceRequest(url)};
fetch_params_second.MutableResourceRequest().SetCachePolicy( fetch_params_second.MutableResourceRequest().SetCachePolicy(
...@@ -595,7 +593,7 @@ TEST_F(ResourceFetcherTest, RepetitiveLinkPreloadShouldBeMerged) { ...@@ -595,7 +593,7 @@ TEST_F(ResourceFetcherTest, RepetitiveLinkPreloadShouldBeMerged) {
ASSERT_TRUE(resource1); ASSERT_TRUE(resource1);
EXPECT_TRUE(resource1->IsUnusedPreload()); EXPECT_TRUE(resource1->IsUnusedPreload());
EXPECT_TRUE(fetcher->ContainsAsPreload(resource1)); EXPECT_TRUE(fetcher->ContainsAsPreload(resource1));
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
// The second preload fetch returns the first preload. // The second preload fetch returns the first preload.
Resource* resource2 = MockResource::Fetch(fetch_params_for_preload, fetcher); Resource* resource2 = MockResource::Fetch(fetch_params_for_preload, fetcher);
...@@ -625,7 +623,7 @@ TEST_F(ResourceFetcherTest, RepetitiveSpeculativePreloadShouldBeMerged) { ...@@ -625,7 +623,7 @@ TEST_F(ResourceFetcherTest, RepetitiveSpeculativePreloadShouldBeMerged) {
ASSERT_TRUE(resource1); ASSERT_TRUE(resource1);
EXPECT_TRUE(resource1->IsUnusedPreload()); EXPECT_TRUE(resource1->IsUnusedPreload());
EXPECT_TRUE(fetcher->ContainsAsPreload(resource1)); EXPECT_TRUE(fetcher->ContainsAsPreload(resource1));
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
// The second preload fetch returns the first preload. // The second preload fetch returns the first preload.
Resource* resource2 = MockResource::Fetch(fetch_params_for_preload, fetcher); Resource* resource2 = MockResource::Fetch(fetch_params_for_preload, fetcher);
...@@ -659,7 +657,7 @@ TEST_F(ResourceFetcherTest, SpeculativePreloadShouldBePromotedToLinkePreload) { ...@@ -659,7 +657,7 @@ TEST_F(ResourceFetcherTest, SpeculativePreloadShouldBePromotedToLinkePreload) {
EXPECT_TRUE(resource1->IsUnusedPreload()); EXPECT_TRUE(resource1->IsUnusedPreload());
EXPECT_FALSE(resource1->IsLinkPreload()); EXPECT_FALSE(resource1->IsLinkPreload());
EXPECT_TRUE(fetcher->ContainsAsPreload(resource1)); EXPECT_TRUE(fetcher->ContainsAsPreload(resource1));
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
// The second preload fetch returns the first preload. // The second preload fetch returns the first preload.
Resource* resource2 = Resource* resource2 =
...@@ -692,8 +690,7 @@ TEST_F(ResourceFetcherTest, Revalidate304) { ...@@ -692,8 +690,7 @@ TEST_F(ResourceFetcherTest, Revalidate304) {
ResourceRequest resource_request(url); ResourceRequest resource_request(url);
resource_request.SetRequestContext(WebURLRequest::kRequestContextInternal); resource_request.SetRequestContext(WebURLRequest::kRequestContextInternal);
FetchParameters fetch_params(resource_request); FetchParameters fetch_params(resource_request);
Platform::Current()->GetURLLoaderMockFactory()->RegisterURL( platform_->GetURLLoaderMockFactory()->RegisterURL(url, WebURLResponse(), "");
url, WebURLResponse(), "");
Resource* new_resource = RawResource::Fetch(fetch_params, fetcher); Resource* new_resource = RawResource::Fetch(fetch_params, fetcher);
fetcher->StopFetching(); fetcher->StopFetching();
...@@ -721,7 +718,7 @@ TEST_F(ResourceFetcherTest, LinkPreloadResourceMultipleFetchersAndMove) { ...@@ -721,7 +718,7 @@ TEST_F(ResourceFetcherTest, LinkPreloadResourceMultipleFetchersAndMove) {
new MockResourceClient(new_resource2); new MockResourceClient(new_resource2);
EXPECT_NE(resource, new_resource2); EXPECT_NE(resource, new_resource2);
EXPECT_EQ(0, fetcher2->BlockingRequestCount()); EXPECT_EQ(0, fetcher2->BlockingRequestCount());
Platform::Current()->GetURLLoaderMockFactory()->ServeAsynchronousRequests(); platform_->GetURLLoaderMockFactory()->ServeAsynchronousRequests();
} }
TEST_F(ResourceFetcherTest, ContentTypeDataURL) { TEST_F(ResourceFetcherTest, ContentTypeDataURL) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment