Some role changes not taking effect

The role changes internally, but the object was not reserialized.

Bug: 1167459
Change-Id: I2fcb36a359481e88211397bcc0ddba8a448b2754
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644859Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846196}

content/browser/accessibility/dump_accessibility_tree_browsertest.cc

@@ -2360,6 +2360,11 @@ IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest, AccessibilityRoleChange) {
   RunAriaTest(FILE_PATH_LITERAL("role-change.html"));
 }
 
+IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest,
+                       AccessibilityRoleChangeDelay) {
+  RunAriaTest(FILE_PATH_LITERAL("role-change-delay.html"));
+}
+
 IN_PROC_BROWSER_TEST_P(DumpAccessibilityTreeTest, AccessibilityRuby) {
   RunHtmlTest(FILE_PATH_LITERAL("ruby.html"));
 }

content/test/data/accessibility/aria/role-change-delay-expected-blink.txt

+rootWebArea name='done'
+++genericContainer ignored
+++++genericContainer ignored
+++++++tabList horizontal
+++++++++staticText name='tab list'
+++++++++++inlineTextBox name='tab list'

content/test/data/accessibility/aria/role-change-delay.html

+<!--
+@WAIT-FOR:done
+-->
+<div id="tablist">tab list</div>
+<script>
+setTimeout(() => {
+  document.querySelector('#tablist').setAttribute('role', 'tablist');
+  setTimeout(() => {
+    document.title = 'done';
+  }, 50);
+}, 50);
+</script>

third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

@@ -1568,6 +1568,7 @@ void AXObjectCacheImpl::ProcessInvalidatedObjects(Document& document) {
       }
 
       AXObject* new_object = refresh(object);
+      MarkAXObjectDirty(new_object, false);
 
       // Children might change because child traversal style changed.
       if (new_object &&