Commit 00c701b3 authored by John Z Wu's avatar John Z Wu Committed by Commit Bot

Expose |isPasswordSuggestion| in the public API.

//ios/web_view clients would like to know if a suggestion is for a
password form or not.

Change-Id: I557857494d3e7889713f2fe8462a37a215111fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1345423
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: default avatarHiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609878}
parent ffb3d956
...@@ -23,9 +23,6 @@ NS_ASSUME_NONNULL_BEGIN ...@@ -23,9 +23,6 @@ NS_ASSUME_NONNULL_BEGIN
// The internal autofill form suggestion. // The internal autofill form suggestion.
@property(nonatomic, readonly) FormSuggestion* formSuggestion; @property(nonatomic, readonly) FormSuggestion* formSuggestion;
// YES if this is a password autofill suggestion.
@property(nonatomic, readonly) BOOL isPasswordSuggestion;
@end @end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END
......
...@@ -41,6 +41,7 @@ TEST_F(CWVAutofillSuggestionTest, Initialization) { ...@@ -41,6 +41,7 @@ TEST_F(CWVAutofillSuggestionTest, Initialization) {
EXPECT_NSEQ(formSuggestion.displayDescription, suggestion.displayDescription); EXPECT_NSEQ(formSuggestion.displayDescription, suggestion.displayDescription);
EXPECT_NSEQ(formSuggestion.value, suggestion.value); EXPECT_NSEQ(formSuggestion.value, suggestion.value);
EXPECT_EQ(formSuggestion, suggestion.formSuggestion); EXPECT_EQ(formSuggestion, suggestion.formSuggestion);
EXPECT_FALSE(suggestion.isPasswordSuggestion);
} }
} // namespace ios_web_view } // namespace ios_web_view
...@@ -13,9 +13,9 @@ ...@@ -13,9 +13,9 @@
NS_ASSUME_NONNULL_BEGIN NS_ASSUME_NONNULL_BEGIN
CWV_EXPORT CWV_EXPORT
// Represents a suggestion for a form based off of a single field. // Represents a suggestion for an address, creditcard, or password form based
// In the case that this suggestion is created from a credit card or address // off of a single field. Filling using a suggestion may fill more than one
// profile, filling using a suggestion may fill more than one field at once. // field at once.
// Example: // Example:
// If an address profile is: // If an address profile is:
// John Doe // John Doe
...@@ -60,6 +60,9 @@ CWV_EXPORT ...@@ -60,6 +60,9 @@ CWV_EXPORT
// credit card network icon. // credit card network icon.
@property(nonatomic, readonly, nullable) UIImage* icon; @property(nonatomic, readonly, nullable) UIImage* icon;
// YES if this is a password autofill suggestion.
@property(nonatomic, readonly) BOOL isPasswordSuggestion;
- (instancetype)init NS_UNAVAILABLE; - (instancetype)init NS_UNAVAILABLE;
@end @end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment