Commit 00dd67f5 authored by Avi Drissman's avatar Avi Drissman Committed by Commit Bot

Revert "Create Browser::FromWebContents."

This reverts commit 06b45622.

There already was a function to do this.

BUG=none

Change-Id: I66da553ce7eaecae8945cc1290d8045ff454209b
Reviewed-on: https://chromium-review.googlesource.com/681847Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504163}
parent c60b3abb
...@@ -469,9 +469,8 @@ class NewTabNavigationOrSwapObserver { ...@@ -469,9 +469,8 @@ class NewTabNavigationOrSwapObserver {
if (swap_observer_) if (swap_observer_)
return true; return true;
WebContents* new_tab = content::Details<WebContents>(details).ptr(); WebContents* new_tab = content::Details<WebContents>(details).ptr();
// Get the TabStripModel. Assume this is attached to a Browser.
TabStripModel* tab_strip_model = TabStripModel* tab_strip_model =
Browser::FromWebContents(new_tab)->tab_strip_model(); chrome::FindBrowserWithWebContents(new_tab)->tab_strip_model();
swap_observer_.reset(new NavigationOrSwapObserver(tab_strip_model, swap_observer_.reset(new NavigationOrSwapObserver(tab_strip_model,
new_tab)); new_tab));
swap_observer_->set_did_start_loading(); swap_observer_->set_did_start_loading();
......
...@@ -281,19 +281,6 @@ const extensions::Extension* GetExtensionForOrigin( ...@@ -281,19 +281,6 @@ const extensions::Extension* GetExtensionForOrigin(
#endif #endif
} }
// Stores a pointer to the Browser in the WebContents.
struct BrowserLink : public base::SupportsUserData::Data {
static const char kKey[];
explicit BrowserLink(Browser* browser) : browser(browser) {}
~BrowserLink() override = default;
Browser* browser;
};
// static
const char BrowserLink::kKey[] = "BrowserLink";
} // namespace } // namespace
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
...@@ -587,13 +574,6 @@ Browser::~Browser() { ...@@ -587,13 +574,6 @@ Browser::~Browser() {
select_file_dialog_->ListenerDestroyed(); select_file_dialog_->ListenerDestroyed();
} }
// static
Browser* Browser::FromWebContents(content::WebContents* web_contents) {
const BrowserLink* link =
static_cast<BrowserLink*>(web_contents->GetUserData(&BrowserLink::kKey));
return link ? link->browser : nullptr;
}
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
// Getters & Setters // Getters & Setters
...@@ -2381,14 +2361,6 @@ void Browser::SetAsDelegate(WebContents* web_contents, bool set_delegate) { ...@@ -2381,14 +2361,6 @@ void Browser::SetAsDelegate(WebContents* web_contents, bool set_delegate) {
zoom::ZoomController::FromWebContents(web_contents)->RemoveObserver(this); zoom::ZoomController::FromWebContents(web_contents)->RemoveObserver(this);
content_translate_driver.RemoveObserver(this); content_translate_driver.RemoveObserver(this);
} }
// Update the back-link from the WebContents to Browser.
if (set_delegate) {
web_contents->SetUserData(BrowserLink::kKey,
base::MakeUnique<BrowserLink>(this));
} else {
web_contents->RemoveUserData(BrowserLink::kKey);
}
} }
void Browser::CloseFrame() { void Browser::CloseFrame() {
......
...@@ -219,10 +219,6 @@ class Browser : public TabStripModelObserver, ...@@ -219,10 +219,6 @@ class Browser : public TabStripModelObserver,
explicit Browser(const CreateParams& params); explicit Browser(const CreateParams& params);
~Browser() override; ~Browser() override;
// Returns the Browser that contains the specified WebContents. May return
// null if no Browser has that WebContents as a tab.
static Browser* FromWebContents(content::WebContents* web_contents);
// Set overrides for the initial window bounds and maximized state. // Set overrides for the initial window bounds and maximized state.
void set_override_bounds(const gfx::Rect& bounds) { void set_override_bounds(const gfx::Rect& bounds) {
override_bounds_ = bounds; override_bounds_ = bounds;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment