Commit 0105ae37 authored by Johannes Henkel's avatar Johannes Henkel Committed by Commit Bot

Add BlockedReason::content-type to browser_protocol.pdl.

This way, entries correspond with ResourceRequestBlockedReason.
Also sort entries more logically and update BuildBlockedReason.
Missing content-type is probably a bug / oversight.

Change-Id: I3091d5ec5cd85b0cd51dc8e637c9665bd3bc7448
Reviewed-on: https://chromium-review.googlesource.com/1043388Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555983}
parent c7771da3
...@@ -3461,6 +3461,7 @@ domain Network ...@@ -3461,6 +3461,7 @@ domain Network
origin origin
inspector inspector
subresource-filter subresource-filter
content-type
other other
# HTTP response data. # HTTP response data.
......
...@@ -349,6 +349,9 @@ String ResourcePriorityJSON(ResourceLoadPriority priority) { ...@@ -349,6 +349,9 @@ String ResourcePriorityJSON(ResourceLoadPriority priority) {
String BuildBlockedReason(ResourceRequestBlockedReason reason) { String BuildBlockedReason(ResourceRequestBlockedReason reason) {
switch (reason) { switch (reason) {
case ResourceRequestBlockedReason::kNone:
NOTREACHED();
return protocol::Network::BlockedReasonEnum::Other;
case ResourceRequestBlockedReason::kCSP: case ResourceRequestBlockedReason::kCSP:
return protocol::Network::BlockedReasonEnum::Csp; return protocol::Network::BlockedReasonEnum::Csp;
case ResourceRequestBlockedReason::kMixedContent: case ResourceRequestBlockedReason::kMixedContent:
...@@ -359,13 +362,13 @@ String BuildBlockedReason(ResourceRequestBlockedReason reason) { ...@@ -359,13 +362,13 @@ String BuildBlockedReason(ResourceRequestBlockedReason reason) {
return protocol::Network::BlockedReasonEnum::Inspector; return protocol::Network::BlockedReasonEnum::Inspector;
case ResourceRequestBlockedReason::kSubresourceFilter: case ResourceRequestBlockedReason::kSubresourceFilter:
return protocol::Network::BlockedReasonEnum::SubresourceFilter; return protocol::Network::BlockedReasonEnum::SubresourceFilter;
case ResourceRequestBlockedReason::kContentType:
return protocol::Network::BlockedReasonEnum::ContentType;
case ResourceRequestBlockedReason::kOther: case ResourceRequestBlockedReason::kOther:
return protocol::Network::BlockedReasonEnum::Other; return protocol::Network::BlockedReasonEnum::Other;
case ResourceRequestBlockedReason::kNone:
default:
NOTREACHED();
return protocol::Network::BlockedReasonEnum::Other;
} }
NOTREACHED();
return protocol::Network::BlockedReasonEnum::Other;
} }
WebConnectionType ToWebConnectionType(const String& connection_type) { WebConnectionType ToWebConnectionType(const String& connection_type) {
......
...@@ -855,6 +855,12 @@ Network.NetworkRequestNode = class extends Network.NetworkNode { ...@@ -855,6 +855,12 @@ Network.NetworkRequestNode = class extends Network.NetworkNode {
case Protocol.Network.BlockedReason.Inspector: case Protocol.Network.BlockedReason.Inspector:
reason = Common.UIString('devtools'); reason = Common.UIString('devtools');
break; break;
case Protocol.Network.BlockedReason.SubresourceFilter:
reason = Common.UIString('subresource-filter');
break;
case Protocol.Network.BlockedReason.ContentType:
reason = Common.UIString('content-type');
break;
case Protocol.Network.BlockedReason.Other: case Protocol.Network.BlockedReason.Other:
reason = Common.UIString('other'); reason = Common.UIString('other');
break; break;
......
...@@ -48,15 +48,19 @@ ...@@ -48,15 +48,19 @@
namespace blink { namespace blink {
// NOTE: If updating this enum, also update
// BuildResourceRequestReason in inspector_network_agent.cc and
// BlockedReasonEnum in browser_protocol.pdl and
// Network.NetworkRequestNode in NetworkDataGridNode.js.
enum class ResourceRequestBlockedReason { enum class ResourceRequestBlockedReason {
kNone,
kCSP, kCSP,
kMixedContent, kMixedContent,
kOrigin, kOrigin,
kInspector, kInspector,
kSubresourceFilter, kSubresourceFilter,
kOther,
kContentType, kContentType,
kNone kOther,
}; };
enum InputToLoadPerfMetricReportPolicy : uint8_t { enum InputToLoadPerfMetricReportPolicy : uint8_t {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment