Commit 011e9a5f authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

cache storage: Remove SetSideData mojo message

This message was used for setting service worker V8 code caching
outside install events. This feature was removed so remove the
message too.

Bug: 915081
Change-Id: I7cf79c6b59b16e3fc015806594bcb987a22c0b52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829621Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#701036}
parent ef3ef0cf
...@@ -330,30 +330,6 @@ class CacheStorageDispatcherHost::CacheImpl ...@@ -330,30 +330,6 @@ class CacheStorageDispatcherHost::CacheImpl
mojo::GetBadMessageCallback())); mojo::GetBadMessageCallback()));
} }
void SetSideData(const GURL& url,
base::Time response_time,
base::span<const uint8_t> side_data,
int64_t trace_id,
SetSideDataCallback callback) override {
DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
TRACE_EVENT_WITH_FLOW1("CacheStorage",
"CacheStorageDispatcherHost::CacheImpl::SetSideData",
TRACE_ID_GLOBAL(trace_id),
TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT,
"url", url.spec());
content::CacheStorageCache* cache = cache_handle_.value();
if (!cache) {
std::move(callback).Run(blink::mojom::CacheStorageError::kErrorNotFound);
return;
}
scoped_refptr<net::IOBuffer> buffer =
base::MakeRefCounted<net::IOBuffer>(side_data.size());
if (!side_data.empty())
memcpy(buffer->data(), &side_data.front(), side_data.size());
cache->WriteSideData(std::move(callback), url, response_time, trace_id,
std::move(buffer), side_data.size());
}
CacheStorageCacheHandle cache_handle_; CacheStorageCacheHandle cache_handle_;
SEQUENCE_CHECKER(sequence_checker_); SEQUENCE_CHECKER(sequence_checker_);
DISALLOW_COPY_AND_ASSIGN(CacheImpl); DISALLOW_COPY_AND_ASSIGN(CacheImpl);
......
...@@ -5,11 +5,9 @@ ...@@ -5,11 +5,9 @@
module blink.mojom; module blink.mojom;
import "mojo/public/mojom/base/read_only_buffer.mojom"; import "mojo/public/mojom/base/read_only_buffer.mojom";
import "mojo/public/mojom/base/time.mojom";
import "third_party/blink/public/mojom/fetch/fetch_api_response.mojom"; import "third_party/blink/public/mojom/fetch/fetch_api_response.mojom";
import "third_party/blink/public/mojom/fetch/fetch_api_request.mojom"; import "third_party/blink/public/mojom/fetch/fetch_api_request.mojom";
import "mojo/public/mojom/base/string16.mojom"; import "mojo/public/mojom/base/string16.mojom";
import "url/mojom/url.mojom";
// This enum is used in histograms, so do not change the ordering and always // This enum is used in histograms, so do not change the ordering and always
// append new types to the end. // append new types to the end.
...@@ -119,11 +117,6 @@ interface CacheStorageCache { ...@@ -119,11 +117,6 @@ interface CacheStorageCache {
// Perform a batch of operations, used for PUT and DELETE operations. // Perform a batch of operations, used for PUT and DELETE operations.
Batch(array<BatchOperation> batch_operations, int64 trace_id) Batch(array<BatchOperation> batch_operations, int64 trace_id)
=> (CacheStorageVerboseError result); => (CacheStorageVerboseError result);
// Sets |side_data| if there is an entry of which key is |url| and the entry
// has the same |response_time|.
SetSideData(url.mojom.Url url, mojo_base.mojom.Time response_time,
mojo_base.mojom.ReadOnlyBuffer side_data, int64 trace_id) => (CacheStorageError result);
}; };
// Handles global CacheStorage methods, directly relates to methods available on // Handles global CacheStorage methods, directly relates to methods available on
......
...@@ -184,14 +184,6 @@ class ErrorCacheForTests : public mojom::blink::CacheStorageCache { ...@@ -184,14 +184,6 @@ class ErrorCacheForTests : public mojom::blink::CacheStorageCache {
CheckBatchOperationsIfProvided(batch_operations); CheckBatchOperationsIfProvided(batch_operations);
std::move(callback).Run(CacheStorageVerboseError::New(error_, String())); std::move(callback).Run(CacheStorageVerboseError::New(error_, String()));
} }
void SetSideData(const KURL& url,
base::Time response_time,
base::span<const uint8_t> side_data,
int64_t trace_id,
SetSideDataCallback callback) override {
std::move(callback).Run(
blink::mojom::CacheStorageError::kErrorNotImplemented);
}
protected: protected:
void CheckUrlIfProvided(const KURL& url) { void CheckUrlIfProvided(const KURL& url) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment