Added WebState::IsVisible() method.

This method will be used to gracefully handle SSL errors when WebState
is not in a tab.

Bug: None
Change-Id: Iee02ce69deda84d595e6bd5ab815317afb82f12d
Reviewed-on: https://chromium-review.googlesource.com/683464
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504472}

ios/web/public/test/fakes/test_web_state.h

@@ -54,6 +54,7 @@ class TestWebState : public WebState {
   const base::string16& GetTitle() const override;
   bool IsLoading() const override;
   double GetLoadingProgress() const override;
+  bool IsVisible() const override;
   bool IsCrashed() const override;
   bool IsEvicted() const override;
   bool IsBeingDestroyed() const override;
@@ -109,6 +110,7 @@ class TestWebState : public WebState {
   BrowserState* browser_state_;
   bool web_usage_enabled_;
   bool is_loading_;
+  bool is_visible_;
   bool is_crashed_;
   bool is_evicted_;
   CRWContentView* transient_content_view_;

ios/web/public/test/fakes/test_web_state.mm

@@ -31,6 +31,7 @@ TestWebState::TestWebState()
     : browser_state_(nullptr),
       web_usage_enabled_(false),
       is_loading_(false),
+      is_visible_(false),
       is_crashed_(false),
       is_evicted_(false),
       trust_level_(kAbsolute),
@@ -74,11 +75,13 @@ UIView* TestWebState::GetView() {
 }
 
 void TestWebState::WasShown() {
+  is_visible_ = true;
   for (auto& observer : observers_)
     observer.WasShown();
 }
 
 void TestWebState::WasHidden() {
+  is_visible_ = false;
   for (auto& observer : observers_)
     observer.WasHidden();
 }
@@ -186,6 +189,10 @@ double TestWebState::GetLoadingProgress() const {
   return 0.0;
 }
 
+bool TestWebState::IsVisible() const {
+  return is_visible_;
+}
+
 bool TestWebState::IsCrashed() const {
   return is_crashed_;
 }

ios/web/public/web_state/web_state.h

@@ -187,6 +187,10 @@ class WebState : public base::SupportsUserData {
   // (nothing loaded) and 1.0 (fully loaded).
   virtual double GetLoadingProgress() const = 0;
 
+  // Whether the WebState is visible. Returns true after WasShown() call and
+  // false after WasHidden() call.
+  virtual bool IsVisible() const = 0;
+
   // Returns true if the web process backing this WebState is believed to
   // currently be crashed.
   virtual bool IsCrashed() const = 0;

ios/web/web_state/ui/crw_web_controller.h

@@ -103,6 +103,10 @@ class WebStateImpl;
 // YES if the web process backing WebView is believed to currently be crashed.
 @property(nonatomic, assign, getter=isWebProcessCrashed) BOOL webProcessCrashed;
 
+// Whether the WebController is visible. Returns YES after wasShown call and
+// NO after wasHidden() call.
+@property(nonatomic, assign, getter=isVisible) BOOL visible;
+
 // Designated initializer. Initializes web controller with |webState|. The
 // calling code must retain the ownership of |webState|.
 - (instancetype)initWithWebState:(web::WebStateImpl*)webState;

ios/web/web_state/ui/crw_web_controller.mm

@@ -923,6 +923,7 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
 @synthesize loadPhase = _loadPhase;
 @synthesize shouldSuppressDialogs = _shouldSuppressDialogs;
 @synthesize webProcessCrashed = _webProcessCrashed;
+@synthesize visible = _visible;
 @synthesize nativeProvider = _nativeProvider;
 @synthesize swipeRecognizerProvider = _swipeRecognizerProvider;
 @synthesize webViewProxy = _webViewProxy;
@@ -2769,12 +2770,14 @@ registerLoadRequestForURL:(const GURL&)requestURL
 }
 
 - (void)wasShown {
+  self.visible = YES;
   if ([self.nativeController respondsToSelector:@selector(wasShown)]) {
     [self.nativeController wasShown];
   }
 }
 
 - (void)wasHidden {
+  self.visible = NO;
   if (_isHalted)
     return;
   [self recordStateInHistory];

ios/web/web_state/web_state_impl.h

@@ -211,6 +211,7 @@ class WebStateImpl : public WebState, public NavigationManagerDelegate {
   bool IsLoading() const override;
   double GetLoadingProgress() const override;
   bool IsCrashed() const override;
+  bool IsVisible() const override;
   bool IsEvicted() const override;
   bool IsBeingDestroyed() const override;
   const GURL& GetVisibleURL() const override;

ios/web/web_state/web_state_impl.mm

@@ -244,6 +244,10 @@ bool WebStateImpl::IsCrashed() const {
   return [web_controller_ isWebProcessCrashed];
 }
 
+bool WebStateImpl::IsVisible() const {
+  return [web_controller_ isVisible];
+}
+
 bool WebStateImpl::IsEvicted() const {
   return ![web_controller_ isViewAlive];
 }

ios/web/web_state/web_state_impl_unittest.mm

@@ -266,16 +266,20 @@ TEST_F(WebStateImplTest, ObserverTest) {
   EXPECT_EQ(web_state_.get(), observer->web_state());
 
   // Test that WasShown() is called.
+  ASSERT_FALSE(web_state_->IsVisible());
   ASSERT_FALSE(observer->was_shown_info());
   web_state_->WasShown();
   ASSERT_TRUE(observer->was_shown_info());
   EXPECT_EQ(web_state_.get(), observer->was_shown_info()->web_state);
+  EXPECT_TRUE(web_state_->IsVisible());
 
   // Test that WasHidden() is called.
+  ASSERT_TRUE(web_state_->IsVisible());
   ASSERT_FALSE(observer->was_hidden_info());
   web_state_->WasHidden();
   ASSERT_TRUE(observer->was_hidden_info());
   EXPECT_EQ(web_state_.get(), observer->was_hidden_info()->web_state);
+  EXPECT_FALSE(web_state_->IsVisible());
 
   // Test that LoadProgressChanged() is called.
   ASSERT_FALSE(observer->change_loading_progress_info());