Commit 0143532e authored by Dominique Fauteux-Chapleau's avatar Dominique Fauteux-Chapleau Committed by Commit Bot

Update DeepScanAccessPoint comment to clarify it's usage

Now that the access point is used for something more than just metrics,
it should be clear that the existing values should not be used again
for other purposes.

Change-Id: I92eeba7e9c2ea2605b3d58476a414355f53de6da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028167Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736845}
parent e417e719
...@@ -27,15 +27,26 @@ void MaybeReportDeepScanningVerdict(Profile* profile, ...@@ -27,15 +27,26 @@ void MaybeReportDeepScanningVerdict(Profile* profile,
BinaryUploadService::Result result, BinaryUploadService::Result result,
DeepScanningClientResponse response); DeepScanningClientResponse response);
// Access points used to record UMA metrics. Adding an access point here // Access points used to record UMA metrics and specify which code location is
// requires updating histograms.xml by adding histograms with names // initiating a deep scan. Any new caller of
// DeepScanningDialogDelegate::ShowForWebContents should add an access point
// here instead of re-using an existing value. histograms.xml should also be
// updated by adding histograms with names
// "SafeBrowsing.DeepScan.<access-point>.BytesPerSeconds" // "SafeBrowsing.DeepScan.<access-point>.BytesPerSeconds"
// "SafeBrowsing.DeepScan.<access-point>.Duration" // "SafeBrowsing.DeepScan.<access-point>.Duration"
// "SafeBrowsing.DeepScan.<access-point>.<result>.Duration" // "SafeBrowsing.DeepScan.<access-point>.<result>.Duration"
// for the new access point and every possible result.
enum class DeepScanAccessPoint { enum class DeepScanAccessPoint {
// A deep scan was initiated from downloading 1+ file(s).
DOWNLOAD, DOWNLOAD,
// A deep scan was initiated from uploading 1+ file(s) via a system dialog.
UPLOAD, UPLOAD,
// A deep scan was initiated from drag-and-dropping text or 1+ file(s).
DRAG_AND_DROP, DRAG_AND_DROP,
// A deep scan was initiated from pasting text.
PASTE, PASTE,
}; };
std::string DeepScanAccessPointToString(DeepScanAccessPoint access_point); std::string DeepScanAccessPointToString(DeepScanAccessPoint access_point);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment