Commit 01463be0 authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

bind-gen: Support stopping the old bindings generation of IDL callback

Supports stopping the old bindings generation of IDL callback
functions so that we can enable the new bindings generator.

Bug: 839389
Change-Id: Ic84f8b6630d2f77983e551083a93c2de3423f954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434184Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811161}
parent 1aa16c70
...@@ -52,6 +52,9 @@ def parse_options(): ...@@ -52,6 +52,9 @@ def parse_options():
'--cache-directory', '--cache-directory',
help='cache directory, defaults to output directory') help='cache directory, defaults to output directory')
parser.add_option('--generate-impl', action='store_true', default=False) parser.add_option('--generate-impl', action='store_true', default=False)
parser.add_option('--generate-impl-skip-callback-function',
action='store_true',
default=False)
parser.add_option( parser.add_option(
'--read-idl-list-from-file', action='store_true', default=False) '--read-idl-list-from-file', action='store_true', default=False)
parser.add_option('--output-directory') parser.add_option('--output-directory')
...@@ -190,8 +193,9 @@ def main(): ...@@ -190,8 +193,9 @@ def main():
options, input_filenames) options, input_filenames)
generate_union_type_containers(CodeGeneratorUnionType, info_provider, generate_union_type_containers(CodeGeneratorUnionType, info_provider,
options) options)
generate_callback_function_impl(CodeGeneratorCallbackFunction, if not options.generate_impl_skip_callback_function:
info_provider, options) generate_callback_function_impl(CodeGeneratorCallbackFunction,
info_provider, options)
else: else:
generate_bindings(CodeGeneratorV8, info_provider, options, generate_bindings(CodeGeneratorV8, info_provider, options,
input_filenames) input_filenames)
......
...@@ -287,8 +287,11 @@ template("idl_impl") { ...@@ -287,8 +287,11 @@ template("idl_impl") {
"--target-component", "--target-component",
invoker.target_component, invoker.target_component,
"--generate-impl", "--generate-impl",
rebase_path(idl_files_list, root_build_dir),
] ]
if (use_blink_v8_binding_new_idl_callback_function) {
args += [ "--generate-impl-skip-callback-function" ]
}
args += [ rebase_path(idl_files_list, root_build_dir) ]
deps = [ deps = [
"//third_party/blink/renderer/bindings:interfaces_info", "//third_party/blink/renderer/bindings:interfaces_info",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment