Commit 015707c1 authored by Kent Tamura's avatar Kent Tamura Committed by Commit Bot

Blink loader: Reduce the size of resource_client.h

resource_client.h is used in 1,600+ compilation units, and this CL
reduces its estimated pre-processed size from 4.04MB to 1.73MB.

Bug: 242216
Change-Id: Iae174451fe424d9765b0ada17c0fef8e9190839c
Reviewed-on: https://chromium-review.googlesource.com/1124269Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572168}
parent 8381e35c
......@@ -42,6 +42,7 @@ blink_platform_sources("loader") {
"fetch/raw_resource.h",
"fetch/resource.cc",
"fetch/resource.h",
"fetch/resource_client.cc",
"fetch/resource_client.h",
"fetch/resource_client_walker.h",
"fetch/resource_error.cc",
......
/*
Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
rights reserved.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Library General Public
License as published by the Free Software Foundation; either
version 2 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Library General Public License for more details.
You should have received a copy of the GNU Library General Public License
along with this library; see the file COPYING.LIB. If not, write to
the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
Boston, MA 02110-1301, USA.
This class provides all functionality needed for loading images, style
sheets and html pages from the web. It has a memory cache for these objects.
*/
#include "third_party/blink/renderer/platform/loader/fetch/resource_client.h"
#include "third_party/blink/renderer/platform/loader/fetch/resource.h"
namespace blink {
void ResourceClient::Trace(Visitor* visitor) {
visitor->Trace(resource_);
}
void ResourceClient::SetResource(Resource* new_resource,
base::SingleThreadTaskRunner* task_runner) {
if (new_resource == resource_)
return;
// Some ResourceClient implementations reenter this so we need to
// prevent double removal.
if (Resource* old_resource = resource_.Release())
old_resource->RemoveClient(this);
resource_ = new_resource;
if (resource_)
resource_->AddClient(this, task_runner);
}
} // namespace blink
......@@ -27,13 +27,18 @@
#define THIRD_PARTY_BLINK_RENDERER_PLATFORM_LOADER_FETCH_RESOURCE_CLIENT_H_
#include "third_party/blink/renderer/platform/heap/handle.h"
#include "third_party/blink/renderer/platform/loader/fetch/resource.h"
#include "third_party/blink/renderer/platform/platform_export.h"
#include "third_party/blink/renderer/platform/wtf/forward.h"
#include "third_party/blink/renderer/platform/wtf/text/wtf_string.h"
namespace base {
class SingleThreadTaskRunner;
}
namespace blink {
class Resource;
class PLATFORM_EXPORT ResourceClient : public GarbageCollectedMixin {
USING_PRE_FINALIZER(ResourceClient, ClearResource);
......@@ -69,7 +74,7 @@ class PLATFORM_EXPORT ResourceClient : public GarbageCollectedMixin {
// Name for debugging, e.g. shown in memory-infra.
virtual String DebugName() const = 0;
void Trace(blink::Visitor* visitor) override { visitor->Trace(resource_); }
void Trace(Visitor* visitor) override;
protected:
ResourceClient() = default;
......@@ -87,18 +92,7 @@ class PLATFORM_EXPORT ResourceClient : public GarbageCollectedMixin {
friend class CSSFontFaceSrcValue;
void SetResource(Resource* new_resource,
base::SingleThreadTaskRunner* task_runner) {
if (new_resource == resource_)
return;
// Some ResourceClient implementations reenter this so
// we need to prevent double removal.
if (Resource* old_resource = resource_.Release())
old_resource->RemoveClient(this);
resource_ = new_resource;
if (resource_)
resource_->AddClient(this, task_runner);
}
base::SingleThreadTaskRunner* task_runner);
Member<Resource> resource_;
};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment