Commit 0157ab03 authored by Anthony Cui's avatar Anthony Cui Committed by Commit Bot

Add accessible name to TranslateBubbleView target_language_combobox_

Bug: 1145384
Change-Id: I5eb7f1a9599eefe4e7cd0e6992f1322c4b6a5db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518248Reviewed-by: default avatarScott Little <sclittle@chromium.org>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824061}
parent ba556d76
...@@ -8464,6 +8464,9 @@ Please help our engineers fix this problem. Tell us what happened right before y ...@@ -8464,6 +8464,9 @@ Please help our engineers fix this problem. Tell us what happened right before y
<message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE_TITLE" desc="Title text for the translate bubble label when the page could not be translated."> <message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE_TITLE" desc="Title text for the translate bubble label when the page could not be translated.">
This page could not be translated This page could not be translated
</message> </message>
<message name="IDS_TRANSLATE_BUBBLE_TARGET_LANG_COMBOBOX_ACCNAME" desc="Accessible name for the target language selection combobox.">
Choose the language to translate the page to
</message>
<if expr="not use_titlecase"> <if expr="not use_titlecase">
<message name="IDS_TRANSLATE_BUBBLE_ADVANCED_BUTTON" desc="Text to show for the translate bubble button to jump to the advanced panel."> <message name="IDS_TRANSLATE_BUBBLE_ADVANCED_BUTTON" desc="Text to show for the translate bubble button to jump to the advanced panel.">
Options Options
......
c5019d7b57ae9cf262bdcd39914d72bbeb6d5c63
\ No newline at end of file
...@@ -840,6 +840,8 @@ std::unique_ptr<views::View> TranslateBubbleView::CreateViewAdvancedTarget() { ...@@ -840,6 +840,8 @@ std::unique_ptr<views::View> TranslateBubbleView::CreateViewAdvancedTarget() {
target_language_combobox->SetCallback(base::BindRepeating( target_language_combobox->SetCallback(base::BindRepeating(
&TranslateBubbleView::TargetLanguageChanged, base::Unretained(this))); &TranslateBubbleView::TargetLanguageChanged, base::Unretained(this)));
target_language_combobox->SetAccessibleName(l10n_util::GetStringUTF16(
IDS_TRANSLATE_BUBBLE_TARGET_LANG_COMBOBOX_ACCNAME));
target_language_combobox_ = target_language_combobox.get(); target_language_combobox_ = target_language_combobox.get();
auto advanced_done_button = std::make_unique<views::MdTextButton>( auto advanced_done_button = std::make_unique<views::MdTextButton>(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment