Commit 0164b1b2 authored by Tanisha Mandre's avatar Tanisha Mandre Committed by Commit Bot

Add Metrics to Credit Card Scanner

- MobileCreditCardScannerClose - Scanner closed using cancel button without scanning a card.
- MobileCreditCardScannerError - Scanner closed from alert due to error.
- MobileCreditCardScannerScannedCode - Scanner closed after successfully scanning a card.

Bug:989432

Change-Id: I6457867e76ddab986fee643812933fed75be9a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763689Reviewed-by: default avatarMark Cogan <marq@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Cr-Commit-Position: refs/heads/master@{#689393}
parent fc796d6d
...@@ -70,7 +70,7 @@ using base::UserMetricsAction; ...@@ -70,7 +70,7 @@ using base::UserMetricsAction;
case scannerViewController::ERROR_DIALOG: case scannerViewController::ERROR_DIALOG:
base::RecordAction(UserMetricsAction("MobileQRScannerError")); base::RecordAction(UserMetricsAction("MobileQRScannerError"));
break; break;
case scannerViewController::SCANNED_CODE: case scannerViewController::SCAN_COMPLETE:
base::RecordAction(UserMetricsAction("MobileQRScannerScannedCode")); base::RecordAction(UserMetricsAction("MobileQRScannerScannedCode"));
break; break;
case scannerViewController::IMPOSSIBLY_UNLIKELY_AUTHORIZATION_CHANGE: case scannerViewController::IMPOSSIBLY_UNLIKELY_AUTHORIZATION_CHANGE:
...@@ -95,7 +95,7 @@ using base::UserMetricsAction; ...@@ -95,7 +95,7 @@ using base::UserMetricsAction;
IDS_IOS_SCANNER_SCANNED_ACCESSIBILITY_ANNOUNCEMENT)); IDS_IOS_SCANNER_SCANNED_ACCESSIBILITY_ANNOUNCEMENT));
} else { } else {
[self.scannerView animateScanningResultWithCompletion:^void(void) { [self.scannerView animateScanningResultWithCompletion:^void(void) {
[self dismissForReason:scannerViewController::SCANNED_CODE [self dismissForReason:scannerViewController::SCAN_COMPLETE
withCompletion:^{ withCompletion:^{
[self.queryLoader loadQuery:result immediately:load]; [self.queryLoader loadQuery:result immediately:load];
}]; }];
......
...@@ -16,7 +16,7 @@ namespace scannerViewController { ...@@ -16,7 +16,7 @@ namespace scannerViewController {
enum DismissalReason { enum DismissalReason {
CLOSE_BUTTON, CLOSE_BUTTON,
ERROR_DIALOG, ERROR_DIALOG,
SCANNED_CODE, SCAN_COMPLETE,
// Not reported. Should be kept last of enum. // Not reported. Should be kept last of enum.
IMPOSSIBLY_UNLIKELY_AUTHORIZATION_CHANGE IMPOSSIBLY_UNLIKELY_AUTHORIZATION_CHANGE
}; };
......
...@@ -253,7 +253,7 @@ using base::UserMetricsAction; ...@@ -253,7 +253,7 @@ using base::UserMetricsAction;
l10n_util::GetNSString( l10n_util::GetNSString(
IDS_IOS_SCANNER_SCANNED_ACCESSIBILITY_ANNOUNCEMENT)]) { IDS_IOS_SCANNER_SCANNED_ACCESSIBILITY_ANNOUNCEMENT)]) {
DCHECK(_result); DCHECK(_result);
[self dismissForReason:scannerViewController::SCANNED_CODE [self dismissForReason:scannerViewController::SCAN_COMPLETE
withCompletion:^{ withCompletion:^{
[self.queryLoader loadQuery:_result [self.queryLoader loadQuery:_result
immediately:_loadResultImmediately]; immediately:_loadResultImmediately];
......
...@@ -38,6 +38,26 @@ using base::UserMetricsAction; ...@@ -38,6 +38,26 @@ using base::UserMetricsAction;
initWithCreditCardScannerDelegate:self]; initWithCreditCardScannerDelegate:self];
} }
- (void)dismissForReason:(scannerViewController::DismissalReason)reason
withCompletion:(void (^)(void))completion {
switch (reason) {
case scannerViewController::CLOSE_BUTTON:
base::RecordAction(UserMetricsAction("MobileCreditCardScannerClose"));
break;
case scannerViewController::ERROR_DIALOG:
base::RecordAction(UserMetricsAction("MobileCreditCardScannerError"));
break;
case scannerViewController::SCAN_COMPLETE:
base::RecordAction(
UserMetricsAction("MobileCreditCardScannerScannedCard"));
break;
case scannerViewController::IMPOSSIBLY_UNLIKELY_AUTHORIZATION_CHANGE:
break;
}
[super dismissForReason:reason withCompletion:completion];
}
#pragma mark - CreditCardScannerCameraControllerDelegate #pragma mark - CreditCardScannerCameraControllerDelegate
- (void)receiveCreditCardScannerResult:(CMSampleBufferRef)sampleBuffer { - (void)receiveCreditCardScannerResult:(CMSampleBufferRef)sampleBuffer {
......
...@@ -11873,6 +11873,27 @@ should be able to be added at any place in this file. ...@@ -11873,6 +11873,27 @@ should be able to be added at any place in this file.
<description>Please enter the description of this user action.</description> <description>Please enter the description of this user action.</description>
</action> </action>
<action name="MobileCreditCardScannerClose">
<owner>gambard@chromium.org</owner>
<description>
User closed the Credit Card Scanner without scanning a credit card.
</description>
</action>
<action name="MobileCreditCardScannerError">
<owner>gambard@chromium.org</owner>
<description>
User closed the Credit Card Scanner from an error dialog.
</description>
</action>
<action name="MobileCreditCardScannerScannedCard">
<owner>gambard@chromium.org</owner>
<description>
User scanned a credit card using the Credit Card Scanner.
</description>
</action>
<action name="MobileCustomFeedback"> <action name="MobileCustomFeedback">
<obsolete> <obsolete>
Deprecated 12/2018. CustomFeedback never shipped to 100% and is no longer Deprecated 12/2018. CustomFeedback never shipped to 100% and is no longer
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment