Commit 0170b0a7 authored by Sky Malice's avatar Sky Malice Committed by Commit Bot

[Feed] Suppress scheduled refreshes on clear history.

Bug: 831648
Change-Id: Ibaca5b3501997d0c4538a9d8a79ae6050c10ec01
Reviewed-on: https://chromium-review.googlesource.com/1131692
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: default avatarMartin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576117}
parent ff2b64b9
......@@ -17,6 +17,7 @@
#include "base/metrics/user_metrics.h"
#include "base/task_scheduler/post_task.h"
#include "build/build_config.h"
#include "chrome/browser/android/feed/feed_host_service_factory.h"
#include "chrome/browser/autofill/personal_data_manager_factory.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/browser_process.h"
......@@ -73,6 +74,8 @@
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h"
#include "components/device_event_log/device_event_log.h"
#include "components/domain_reliability/service.h"
#include "components/feed/core/feed_host_service.h"
#include "components/feed/core/feed_scheduler_host.h"
#include "components/history/core/browser/history_service.h"
#include "components/language/core/browser/url_language_histogram.h"
#include "components/nacl/browser/nacl_browser.h"
......@@ -408,6 +411,14 @@ void ChromeBrowsingDataRemoverDelegate::RemoveEmbedderData(
filter, bookmark_model);
}
#if defined(OS_ANDROID)
feed::FeedHostService* feed_host_service =
feed::FeedHostServiceFactory::GetForBrowserContext(profile_);
if (feed_host_service) {
feed_host_service->GetSchedulerHost()->OnHistoryCleared();
}
#endif // defined(OS_ANDROID)
language::UrlLanguageHistogram* language_histogram =
UrlLanguageHistogramFactory::GetForBrowserContext(profile_);
if (language_histogram) {
......
......@@ -67,6 +67,7 @@
#include "components/domain_reliability/monitor.h"
#include "components/domain_reliability/service.h"
#include "components/favicon/core/favicon_service.h"
#include "components/feed/core/pref_names.h"
#include "components/history/core/browser/history_service.h"
#include "components/language/core/browser/url_language_histogram.h"
#include "components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h"
......@@ -2957,4 +2958,14 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, WipeOriginVerifierData) {
customtabs::OriginVerifier::GetClearBrowsingDataCallCountForTesting());
}
TEST_F(ChromeBrowsingDataRemoverDelegateTest, FeedClearsLastFetchAttempt) {
PrefService* prefs = GetProfile()->GetPrefs();
prefs->SetTime(feed::prefs::kLastFetchAttemptTime, base::Time::Now());
BlockUntilBrowsingDataRemoved(
base::Time(), base::Time::Max(),
ChromeBrowsingDataRemoverDelegate::DATA_TYPE_HISTORY, false);
EXPECT_EQ(base::Time(), prefs->GetTime(feed::prefs::kLastFetchAttemptTime));
}
#endif // defined(OS_ANDROID)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment