Commit 0179aee4 authored by jonross's avatar jonross Committed by Commit Bot

Remove Dead ViewHostMsg_ResizeOrRepaint_ACK_Flags

ViewHostMsg_ResizeOrRepaint_ACK_Flags is no longer used. This removes it and
updates the comments on ViewMsg_SynchronizeVisualProperties to reflec the
current reality.

TBR=piman@chromium.org

Bug: 655231
Change-Id: I388ab96bd0bdf46a84f4e1e92bd8378fcc4dd834
Reviewed-on: https://chromium-review.googlesource.com/1216069
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: default avatarKen Buchanan <kenrb@chromium.org>
Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590004}
parent 5bc2e3de
...@@ -49,7 +49,6 @@ ...@@ -49,7 +49,6 @@
#include "content/common/input/input_handler.mojom.h" #include "content/common/input/input_handler.mojom.h"
#include "content/common/render_frame_metadata.mojom.h" #include "content/common/render_frame_metadata.mojom.h"
#include "content/common/render_widget_surface_properties.h" #include "content/common/render_widget_surface_properties.h"
#include "content/common/view_message_enums.h"
#include "content/common/widget.mojom.h" #include "content/common/widget.mojom.h"
#include "content/public/browser/render_widget_host.h" #include "content/public/browser/render_widget_host.h"
#include "content/public/common/input_event_ack_state.h" #include "content/public/common/input_event_ack_state.h"
......
...@@ -267,7 +267,6 @@ source_set("common") { ...@@ -267,7 +267,6 @@ source_set("common") {
"url_schemes.cc", "url_schemes.cc",
"url_schemes.h", "url_schemes.h",
"user_agent.cc", "user_agent.cc",
"view_message_enums.h",
"view_messages.h", "view_messages.h",
"visual_properties.cc", "visual_properties.cc",
"visual_properties.h", "visual_properties.h",
......
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include "content/common/ax_content_node_data.h" #include "content/common/ax_content_node_data.h"
#include "content/common/content_export.h" #include "content/common/content_export.h"
#include "content/common/content_param_traits.h" #include "content/common/content_param_traits.h"
#include "content/common/view_message_enums.h"
#include "ipc/ipc_message_macros.h" #include "ipc/ipc_message_macros.h"
#include "ipc/ipc_message_utils.h" #include "ipc/ipc_message_utils.h"
#include "ipc/ipc_param_traits.h" #include "ipc/ipc_param_traits.h"
......
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CONTENT_COMMON_VIEW_MESSAGE_ENUMS_H_
#define CONTENT_COMMON_VIEW_MESSAGE_ENUMS_H_
#include "ipc/ipc_message_macros.h"
// Values that may be OR'd together to form the 'flags' parameter of a
// ViewHostMsg_ResizeOrRepaint_ACK_Params structure.
struct ViewHostMsg_ResizeOrRepaint_ACK_Flags {
enum {
IS_RESIZE_ACK = 1 << 0,
IS_REPAINT_ACK = 1 << 2,
};
static bool is_resize_ack(int flags) {
return (flags & IS_RESIZE_ACK) != 0;
}
static bool is_repaint_ack(int flags) {
return (flags & IS_REPAINT_ACK) != 0;
}
};
#endif // CONTENT_COMMON_VIEW_MESSAGE_ENUMS_H_
...@@ -29,7 +29,6 @@ ...@@ -29,7 +29,6 @@
#include "content/common/frame_replication_state.h" #include "content/common/frame_replication_state.h"
#include "content/common/navigation_gesture.h" #include "content/common/navigation_gesture.h"
#include "content/common/text_input_state.h" #include "content/common/text_input_state.h"
#include "content/common/view_message_enums.h"
#include "content/common/visual_properties.h" #include "content/common/visual_properties.h"
#include "content/public/common/common_param_traits.h" #include "content/public/common/common_param_traits.h"
#include "content/public/common/menu_item.h" #include "content/public/common/menu_item.h"
...@@ -249,10 +248,9 @@ IPC_MESSAGE_ROUTED0(ViewMsg_Close) ...@@ -249,10 +248,9 @@ IPC_MESSAGE_ROUTED0(ViewMsg_Close)
// Tells the renderer to update visual properties. A // Tells the renderer to update visual properties. A
// ViewHostMsg_ResizeOrRepaint_ACK message is generated in response provided // ViewHostMsg_ResizeOrRepaint_ACK message is generated in response provided
// new_size is not empty and not equal to the view's current size. The // new_size is not empty and not equal to the view's current size. The resulting
// generated ViewHostMsg_ResizeOrRepaint_ACK // CompositorFrame will produce a RenderFrameMetadata containing a new
// message will have the IS_RESIZE_ACK flag set. It also receives the resizer // LocalSurfaceId. This acts as a form of ACK for this message.
// rect so that we don't have to fetch it every time WebKit asks for it.
IPC_MESSAGE_ROUTED1(ViewMsg_SynchronizeVisualProperties, IPC_MESSAGE_ROUTED1(ViewMsg_SynchronizeVisualProperties,
content::VisualProperties /* params */) content::VisualProperties /* params */)
......
...@@ -10,7 +10,6 @@ ...@@ -10,7 +10,6 @@
#include "build/build_config.h" #include "build/build_config.h"
#include "content/common/accessibility_messages.h" #include "content/common/accessibility_messages.h"
#include "content/common/frame_messages.h" #include "content/common/frame_messages.h"
#include "content/common/view_message_enums.h"
#include "content/public/common/content_switches.h" #include "content/public/common/content_switches.h"
#include "content/public/test/render_view_test.h" #include "content/public/test/render_view_test.h"
#include "content/renderer/accessibility/render_accessibility_impl.h" #include "content/renderer/accessibility/render_accessibility_impl.h"
......
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "content/common/frame_messages.h" #include "content/common/frame_messages.h"
#include "content/common/view_message_enums.h"
#include "content/public/common/content_constants.h" #include "content/public/common/content_constants.h"
#include "content/public/test/frame_load_waiter.h" #include "content/public/test/frame_load_waiter.h"
#include "content/public/test/render_view_test.h" #include "content/public/test/render_view_test.h"
......
...@@ -28,7 +28,6 @@ ...@@ -28,7 +28,6 @@
#include "content/common/content_export.h" #include "content/common/content_export.h"
#include "content/common/frame_message_enums.h" #include "content/common/frame_message_enums.h"
#include "content/common/navigation_gesture.h" #include "content/common/navigation_gesture.h"
#include "content/common/view_message_enums.h"
#include "content/public/common/browser_controls_state.h" #include "content/public/common/browser_controls_state.h"
#include "content/public/common/drop_data.h" #include "content/public/common/drop_data.h"
#include "content/public/common/page_zoom.h" #include "content/public/common/page_zoom.h"
......
...@@ -11,7 +11,6 @@ ...@@ -11,7 +11,6 @@
#include "content/browser/frame_host/render_frame_host_impl.h" #include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h" #include "content/browser/renderer_host/render_widget_host_view_base.h"
#include "content/browser/web_contents/web_contents_impl.h" #include "content/browser/web_contents/web_contents_impl.h"
#include "content/common/view_message_enums.h"
#include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents.h"
#include "content/public/common/url_constants.h" #include "content/public/common/url_constants.h"
#include "content/public/test/test_utils.h" #include "content/public/test/test_utils.h"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment