Revert "Null-check LocalFrame::Client() before accessing in LocalWindowProxy"
This reverts commit 250e22d9. Reason for revert: Not needed anymore, since another fix was landed. Original change's description: > Null-check LocalFrame::Client() before accessing in LocalWindowProxy > > When the frame has already been detached, Client() will be nullptr. > Since we can call LocalWindowProxy methods even when detached, > e.g. through ToV8ContextEvenIfDetached(), we should null-check the client. > > This is a band-aid fix, because we actually should not initialize context > on a detached frame and change ToV8ContextEvenIfDetached to never force > context. However, the proper solution has many risks and needs additional > investigation. > > Bug: 805882 > Change-Id: Idcd6bbc0e6eec9b2de53acfb646b30bd9636d797 > Reviewed-on: https://chromium-review.googlesource.com/949603 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543266} TBR=dgozman@chromium.org,dcheng@chromium.org,peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805882 Change-Id: Ia9bf73134c13c3f0bb2c29e69f9d88dbed336ce6 Reviewed-on: https://chromium-review.googlesource.com/973468Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544782}
Showing
Please register or sign in to comment