Commit 01a92850 authored by Joe Downing's avatar Joe Downing Committed by Commit Bot

Disabling ServiceManagerContextTest.TerminateOnServiceQuit for Windows

Over the last few days we've seen several cases of
{viz_}content_browsertests failing even when all of the retires pass.
The reason for the failure is that the swarming bot cannot clean up the
directory due to child process(es) still running.  The one thing all of
the failures have in common is that the initial run of
TerminateOnServiceQuit timed out.  Perhaps there is some additional
clean up the test framework needs to do in this case.

TBR=rockot@chromium.org

BUG=804937

Change-Id: I6937c038f91f7b254ab7ad2b8005c94ca064a4ee
Reviewed-on: https://chromium-review.googlesource.com/884230Reviewed-by: default avatarJoe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531694}
parent a1110c20
...@@ -116,6 +116,9 @@ IN_PROC_BROWSER_TEST_F(ServiceManagerContextBrowserTest, ...@@ -116,6 +116,9 @@ IN_PROC_BROWSER_TEST_F(ServiceManagerContextBrowserTest,
// crbug.com/804113. // crbug.com/804113.
#if (defined(OS_CHROMEOS) || defined(OS_LINUX)) && defined(ADDRESS_SANITIZER) #if (defined(OS_CHROMEOS) || defined(OS_LINUX)) && defined(ADDRESS_SANITIZER)
#define MAYBE_TerminateOnServiceQuit DISABLED_TerminateOnServiceQuit #define MAYBE_TerminateOnServiceQuit DISABLED_TerminateOnServiceQuit
#elif defined(OS_WIN)
// crbug.com/804937. Causes failures when test times out even if retry passes.
#define MAYBE_TerminateOnServiceQuit DISABLED_TerminateOnServiceQuit
#else #else
#define MAYBE_TerminateOnServiceQuit TerminateOnServiceQuit #define MAYBE_TerminateOnServiceQuit TerminateOnServiceQuit
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment