Commit 01aea553 authored by qyearsley's avatar qyearsley Committed by Commit bot

Refactor SyncBuildAndRunRevision to remove deep nesting.

I also propose to rename this function to just RunTest, because its purpose is to do everything necessary to obtain a build and run a test to get results, and it's a relatively important and high-level function.

"Flat is better than nested."
  -- The Zen of Python, PEP 20.

BUG=

Review URL: https://codereview.chromium.org/484583002

Cr-Commit-Position: refs/heads/master@{#292661}
parent 5780ffac
...@@ -59,13 +59,17 @@ config = { ...@@ -59,13 +59,17 @@ config = {
""" """
config = { config = {
'command': '', 'max_time_minutes': '20',
'good_revision': '', 'metric': 'Total/Total',
'bad_revision': '', 'builder_port': '8341',
'metric': '', 'bug_id': '405188',
'repeat_count':'', 'repeat_count': '20',
'max_time_minutes': '', 'good_revision': '288423',
'truncate_percent':'', 'builder_host': 'master4.golo.chromium.org',
'truncate_percent': '25',
'command': 'tools/perf/run_benchmark -v --browser=release sunspider',
'gs_bucket': 'chrome-perf',
'bad_revision': '288447',
} }
# Workaround git try issue, see crbug.com/257689 # Workaround git try issue, see crbug.com/257689
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment