JsonSchemaCompiler: Rename ConstantName To FeatureNameToConstantName.

This fixes an existing TODO. The current name doesn't clearly specify
what the function does.

BUG=1113513

Change-Id: Id08cd8e56e72abc0ad1059aacf20f989bb99d8f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342754
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802801}

tools/json_schema_compiler/cpp_util.py

@@ -126,8 +126,8 @@ def CloseNamespace(cpp_namespace):
   return c
 
 
-# TODO(karandeepb): Rename to FeatureNameToConstantName.
-def ConstantName(feature_name):
+def FeatureNameToConstantName(feature_name):
+  # type: (str) -> str
   """Returns a kName for a feature's name.
   """
   return ('k' + ''.join(word[0].upper() + word[1:]

tools/json_schema_compiler/features_cc_generator.py

@@ -47,7 +47,8 @@ class _Generator(object):
     )
     for feature in self._feature_defs:
       c.Append('features_["%s"] = %s;'
-                       % (feature.name, cpp_util.ConstantName(feature.name)))
+                       % (feature.name,
+                          cpp_util.FeatureNameToConstantName(feature.name)))
     (c.Eblock()
       .Append('}')
       .Append()
@@ -62,7 +63,7 @@ class _Generator(object):
     )
     for feature in self._feature_defs:
       c.Append('case %s: return "%s";' %
-          (cpp_util.ConstantName(feature.name), feature.name))
+          (cpp_util.FeatureNameToConstantName(feature.name), feature.name))
     (c.Append('case kUnknown: break;')
       .Append('case kEnumBoundary: break;')
       .Eblock()

tools/json_schema_compiler/features_h_generator.py

@@ -93,7 +93,7 @@ class _Generator(object):
       .Append('kUnknown,')
     )
     for feature in self._feature_defs:
-      c.Append('%s,' % cpp_util.ConstantName(feature.name))
+      c.Append('%s,' % cpp_util.FeatureNameToConstantName(feature.name))
     c.Append('kEnumBoundary')
 
     return c