Commit 01ca4ffb authored by Ali Juma's avatar Ali Juma Committed by Commit Bot

[iOS] Add an about:flags entry for Safe Browsing

This adds an about:flags entry for Safe Browsing, to make it easier
to enable and test.

Bug: 1028755
Change-Id: I48bb2c6d20a707a2f44810e71403abd2eb8dda3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105797
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751691}
parent cfa29d6e
......@@ -3417,6 +3417,11 @@
"owners": [ "armax", "guidou" ],
"expiry_milestone": 90
},
{
"name": "safe-browsing-available",
"owners": [ "//ios/chrome/browser/safe_browsing/OWNERS" ],
"expiry_milestone": 85
},
{
"name": "safety-tips",
"owners": [ "jdeblasio", "estark", "meacer" ],
......
......@@ -26,6 +26,7 @@ source_set("flags") {
"//components/omnibox/common",
"//components/password_manager/core/common",
"//components/payments/core",
"//components/safe_browsing/core:features",
"//components/search_provider_logos",
"//components/security_state/core",
"//components/send_tab_to_self",
......
......@@ -39,6 +39,7 @@
#include "components/omnibox/common/omnibox_features.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/payments/core/features.h"
#include "components/safe_browsing/core/features.h"
#include "components/security_state/core/features.h"
#include "components/send_tab_to_self/features.h"
#include "components/signin/core/browser/account_reconcilor.h"
......@@ -577,6 +578,9 @@ const flags_ui::FeatureEntry kFeatureEntries[] = {
flags_ui::kOsIos,
FEATURE_VALUE_TYPE(
web::features::kIOSLookalikeUrlNavigationSuggestionsUI)},
{"safe-browsing-available", flag_descriptions::kSafeBrowsingAvailableName,
flag_descriptions::kSafeBrowsingAvailableDescription, flags_ui::kOsIos,
FEATURE_VALUE_TYPE(safe_browsing::kSafeBrowsingAvailableOnIOS)},
};
// Add all switches from experimental flags to |command_line|.
......
......@@ -327,6 +327,11 @@ const char kReloadSadTabDescription[] =
"When enabled, the first time the renderer crashes, the page is reloaded "
"instead of showing the SadTab";
const char kSafeBrowsingAvailableName[] = "Make Safe Browsing available";
const char kSafeBrowsingAvailableDescription[] =
"When enabled, navigation URLs are compared to Safe Browsing blocklists, "
"subject to an opt-out preference.";
const char kSaveCardInfobarMessagesUIName[] = "Save Card Infobar Messages UI";
const char kSaveCardInfobarMessagesUIDescription[] =
"When enabled, Save Card Infobar uses the new Messages UI.";
......
......@@ -279,6 +279,10 @@ extern const char kPageInfoRefactoringDescription[];
extern const char kReloadSadTabName[];
extern const char kReloadSadTabDescription[];
// Title and description for the flag that makes Safe Browsing available.
extern const char kSafeBrowsingAvailableName[];
extern const char kSafeBrowsingAvailableDescription[];
// Title and description for the flag that enables Messages UI on
// SaveCard Infobars.
extern const char kSaveCardInfobarMessagesUIName[];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment