Rename touch tap function in pointerevent_support.js

In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs.

pointerevent_support.js keeps many commonly used functions in the
pointer event tests. There are click function for all input types,
touch, mouse and pen. So I make the current touch tap function to a
general "clickInTarget" function for all inputs.

Bug: 606367
Change-Id: I8da3e8910c6ec0128a40d38ce6ac21bf24c449a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604328Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658669}

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_sequence_at_implicit_release_on_drag.html

@@ -56,7 +56,7 @@
 
         // Inject touch inputs.
         pointerDragInTarget("touch", target, 'right').then(function() {
-          return touchTapInTarget(button);
+          return clickInTarget("touch", button);
         }).then(function() {
           test_pointer_event.step(function () {
             assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_support.js

@@ -286,9 +286,10 @@ function touchScrollInTarget(target, direction) {
                    .send();
 }
 
-function touchTapInTarget(target) {
+function clickInTarget(pointerType, target) {
+    var pointerId = pointerType + "Pointer1";
     return new test_driver.Actions()
-                   .addPointer("pointer1", "touch")
+                   .addPointer(pointerId, pointerType)
                    .pointerMove(0, 0, {origin: target})
                    .pointerDown()
                    .pointerUp()

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch.html

@@ -115,7 +115,7 @@
                 touchScrollInTarget(scrollTarget, 'down').then(function() {
                     return touchScrollInTarget(scrollTarget, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-inherit_child-none_touch.html

@@ -110,7 +110,7 @@
                 touchScrollInTarget(scrollTarget, 'down').then(function() {
                     return touchScrollInTarget(scrollTarget, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch.html

@@ -110,7 +110,7 @@
                 touchScrollInTarget(scrollTarget, 'down').then(function() {
                     return touchScrollInTarget(scrollTarget, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch.html

@@ -115,7 +115,7 @@
                 touchScrollInTarget(scrollTarget, 'down').then(function() {
                     return touchScrollInTarget(scrollTarget, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-inherit_parent-none_touch.html

@@ -110,7 +110,7 @@
                 touchScrollInTarget(scrollTarget, 'down').then(function() {
                     return touchScrollInTarget(scrollTarget, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-none-css_touch.html

@@ -109,7 +109,7 @@
                 touchScrollInTarget(target0, 'down').then(function() {
                     return touchScrollInTarget(target0, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-pan-x-css_touch.html

@@ -104,7 +104,7 @@
                 touchScrollInTarget(target0, 'down').then(function() {
                     return touchScrollInTarget(target0, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch.html

@@ -109,7 +109,7 @@
                 touchScrollInTarget(target0, 'down').then(function() {
                     return touchScrollInTarget(target0, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");

third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_touch-action-pan-y-css_touch.html

@@ -105,7 +105,7 @@
                 touchScrollInTarget(target0, 'down').then(function() {
                     return touchScrollInTarget(target0, 'right');
                 }).then(function() {
-                    return touchTapInTarget(btnComplete);
+                    return clickInTarget("touch", btnComplete);
                 }).then(function() {
                     test_touchaction.step(function () {
                         assert_true(clickIsReceived, "click should be received before the test finishes");