Commit 01ddc793 authored by Wez's avatar Wez Committed by Commit Bot

[mac] Remove waitWithTimeout from RenderWidgetHostViewMac test.

The waitWithTimeout calls are unnecessary now that browser tests always
run with a default RunLoop timeout configured.

Bug: 1021777
Change-Id: Icc5eab59b739a9b5c00d9c7820b75d5b092e1c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020762
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736029}
parent ecd023d3
...@@ -47,9 +47,7 @@ ...@@ -47,9 +47,7 @@
_run_loop = std::make_unique<base::RunLoop>(); _run_loop = std::make_unique<base::RunLoop>();
} }
- (void)waitWithTimeout:(NSTimeInterval)timeout { - (void)wait {
base::RunLoop::ScopedRunTimeoutForTest run_timeout(
base::TimeDelta::FromSecondsD(timeout), _run_loop->QuitClosure());
_run_loop->Run(); _run_loop->Run();
[self reset]; [self reset];
...@@ -147,14 +145,14 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewMacTest, UpdateInputFlags) { ...@@ -147,14 +145,14 @@ IN_PROC_BROWSER_TEST_F(RenderWidgetHostViewMacTest, UpdateInputFlags) {
initWithRenderWidgetHostViewCocoa:rwhv_cocoa]); initWithRenderWidgetHostViewCocoa:rwhv_cocoa]);
EXPECT_TRUE(ExecJs(shell(), "ta.focus();")); EXPECT_TRUE(ExecJs(shell(), "ta.focus();"));
[flag_change_waiter waitWithTimeout:5]; [flag_change_waiter wait];
EXPECT_FALSE(rwhv_cocoa.textInputFlags & EXPECT_FALSE(rwhv_cocoa.textInputFlags &
blink::kWebTextInputFlagAutocorrectOff); blink::kWebTextInputFlagAutocorrectOff);
EXPECT_TRUE(ExecJs( EXPECT_TRUE(ExecJs(
shell(), shell(),
"ta.setAttribute('autocorrect', 'off'); console.log(ta.outerHTML);")); "ta.setAttribute('autocorrect', 'off'); console.log(ta.outerHTML);"));
[flag_change_waiter waitWithTimeout:5]; [flag_change_waiter wait];
EXPECT_TRUE(rwhv_cocoa.textInputFlags & EXPECT_TRUE(rwhv_cocoa.textInputFlags &
blink::kWebTextInputFlagAutocorrectOff); blink::kWebTextInputFlagAutocorrectOff);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment