Commit 02103339 authored by Hector Carmona's avatar Hector Carmona Committed by Commit Bot

A11y: Extensions - Add role="heading" to title and section titles.

Bug: 876601
Change-Id: I49c8f9730adf76a6612cb108785145465c3b640f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861112
Auto-Submit: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706112}
parent 997ed997
...@@ -178,7 +178,9 @@ ...@@ -178,7 +178,9 @@
data.type, data.type,
'$i18nPolymer{appIcon}', '$i18nPolymer{appIcon}',
'$i18nPolymer{extensionIcon}')]]"> '$i18nPolymer{extensionIcon}')]]">
<span id="name" class="cr-title-text">[[data.name]]</span> <span id="name" class="cr-title-text" role="heading" aria-level="1">
[[data.name]]
</span>
</div> </div>
<div class="section continuation control-line" id="enable-section"> <div class="section continuation control-line" id="enable-section">
<span class$="[[computeEnabledStyle_(data.state)]]"> <span class$="[[computeEnabledStyle_(data.state)]]">
...@@ -258,17 +260,23 @@ ...@@ -258,17 +260,23 @@
</div> </div>
</div> </div>
<div class="section continuation block"> <div class="section continuation block">
<div class="section-title">$i18n{itemDescriptionLabel}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemDescriptionLabel}
</div>
<div class="section-content" id="description"> <div class="section-content" id="description">
[[getDescription_(data.description, '$i18nPolymer{noDescription}')]] [[getDescription_(data.description, '$i18nPolymer{noDescription}')]]
</div> </div>
</div> </div>
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemVersion}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemVersion}
</div>
<div class="section-content">[[data.version]]</div> <div class="section-content">[[data.version]]</div>
</div> </div>
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemSize}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemSize}
</div>
<div class="section-content" id="size"> <div class="section-content" id="size">
<span>[[size_]]</span> <span>[[size_]]</span>
<paper-spinner-lite active="[[!size_]]" hidden="[[size_]]"> <paper-spinner-lite active="[[!size_]]" hidden="[[size_]]">
...@@ -276,12 +284,16 @@ ...@@ -276,12 +284,16 @@
</div> </div>
</div> </div>
<div class="section block" id="id-section" hidden$="[[!inDevMode]]"> <div class="section block" id="id-section" hidden$="[[!inDevMode]]">
<div class="section-title">$i18n{itemIdHeading}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemIdHeading}
</div>
<div class="section-content">[[data.id]]</div> <div class="section-content">[[data.id]]</div>
</div> </div>
<template is="dom-if" if="[[inDevMode]]"> <template is="dom-if" if="[[inDevMode]]">
<div class="section block" id="inspectable-views"> <div class="section block" id="inspectable-views">
<div class="section-title">$i18n{itemInspectViews}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemInspectViews}
</div>
<div class="section-content"> <div class="section-content">
<ul id="inspect-views"> <ul id="inspect-views">
<li hidden="[[data.views.length]]"> <li hidden="[[data.views.length]]">
...@@ -300,7 +312,9 @@ ...@@ -300,7 +312,9 @@
</div> </div>
</template> </template>
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemPermissions}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemPermissions}
</div>
<div class="section-content"> <div class="section-content">
<span id="no-permissions" hidden$="[[hasPermissions_(data.*)]]"> <span id="no-permissions" hidden$="[[hasPermissions_(data.*)]]">
$i18n{itemPermissionsEmpty} $i18n{itemPermissionsEmpty}
...@@ -322,7 +336,9 @@ ...@@ -322,7 +336,9 @@
</div> </div>
</div> </div>
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemSiteAccess}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemSiteAccess}
</div>
<div class="section-content"> <div class="section-content">
<span id="no-site-access" <span id="no-site-access"
hidden$="[[showSiteAccessContent_(data.*)]]"> hidden$="[[showSiteAccessContent_(data.*)]]">
...@@ -349,7 +365,9 @@ ...@@ -349,7 +365,9 @@
<template is="dom-if" <template is="dom-if"
if="[[hasDependentExtensions_(data.dependentExtensions.splices)]]"> if="[[hasDependentExtensions_(data.dependentExtensions.splices)]]">
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemDependencies}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemDependencies}
</div>
<div class="section-content"> <div class="section-content">
<ul id="dependent-extensions-list"> <ul id="dependent-extensions-list">
<template is="dom-repeat" items="[[data.dependentExtensions]]"> <template is="dom-repeat" items="[[data.dependentExtensions]]">
...@@ -405,7 +423,9 @@ ...@@ -405,7 +423,9 @@
id="viewInStore" label="$i18n{viewInStore}" id="viewInStore" label="$i18n{viewInStore}"
on-click="onViewInStoreTap_" external></cr-link-row> on-click="onViewInStoreTap_" external></cr-link-row>
<div class="section block"> <div class="section block">
<div class="section-title">$i18n{itemSource}</div> <div class="section-title" role="heading" aria-level="2">
$i18n{itemSource}
</div>
<div id="source" class="section-content"> <div id="source" class="section-content">
[[computeSourceString_(data.*)]] [[computeSourceString_(data.*)]]
</div> </div>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment