Commit 0212e7bd authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

test: Replace _TEST_CASE_ with _TEST_SUITE_ in...

test: Replace _TEST_CASE_ with _TEST_SUITE_ in /chrome/browser/extensions/api/webrtc_logging_private.

Googletest is (at last) converging with industry-standard terminology
[1]. We previously called test suites "test cases", which was rather
confusing for folks coming from any other testing framework.

Chrome now has a googltest version that supports _TEST_SUITE_ macros
instead of _TEST_CASE_, so this CL cleans up some of the outdated usage.

[1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

This CL was uploaded by git cl split.

R=grunell@chromium.org

Bug: 925652
Change-Id: I02e600e50b04228866f1b2cc050d57158779bc95
Reviewed-on: https://chromium-review.googlesource.com/c/1438379
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: default avatarHenrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626466}
parent 0dc5abde
...@@ -878,7 +878,7 @@ IN_PROC_BROWSER_TEST_F( ...@@ -878,7 +878,7 @@ IN_PROC_BROWSER_TEST_F(
expect_success, error_message); expect_success, error_message);
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
_, _,
WebrtcLoggingPrivateApiStartEventLoggingTestFeatureAndPolicyEnabled, WebrtcLoggingPrivateApiStartEventLoggingTestFeatureAndPolicyEnabled,
::testing::Bool()); ::testing::Bool());
...@@ -920,7 +920,7 @@ IN_PROC_BROWSER_TEST_P( ...@@ -920,7 +920,7 @@ IN_PROC_BROWSER_TEST_P(
expect_success, error_message); expect_success, error_message);
} }
INSTANTIATE_TEST_CASE_P( INSTANTIATE_TEST_SUITE_P(
FeatureEnabled, FeatureEnabled,
WebrtcLoggingPrivateApiStartEventLoggingTestFeatureOrPolicyDisabled, WebrtcLoggingPrivateApiStartEventLoggingTestFeatureOrPolicyDisabled,
::testing::Bool()); ::testing::Bool());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment