Enable isolated splits on all channels

This has been stable on canary/dev and showed very good results in the
beta experiment: go/isolated-splits-experiment

The plan is to run beta/stable experiments in M89 with isolated splits
disabled to get final numbers.

Bug: 1126301
Change-Id: Ifc6ecbc893241b84db57545381d606a0adb1e963
Binary-Size: Increase is unavoidable and comes from symbols being
Binary-Size: duplicated between dex files and resources moved into
Binary-Size: base module.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612278
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842623}

chrome/android/expectations/monochrome_public_bundle.AndroidManifest.expected

 <?xml version="1.0" ?>
 <manifest
+    android:isolatedSplits="true"
     package="org.chromium.chrome.stable"
     platformBuildVersionCode="30"
     platformBuildVersionName="11"
@@ -72,13 +73,14 @@
   <application
       android:allowAudioPlaybackCapture="false"
       android:allowBackup="false"
+      android:appComponentFactory="org.chromium.chrome.browser.base.SplitCompatAppComponentFactory"
       android:extractNativeLibs="false"
       android:icon="@drawable/ic_launcher"
       android:label="@string/app_name"
       android:largeHeap="false"
       android:manageSpaceActivity="@string/manage_space_activity"
       android:multiArch="true"
-      android:name="org.chromium.chrome.browser.MonochromeApplication"
+      android:name="org.chromium.chrome.browser.base.SplitMonochromeApplication"
       android:networkSecurityConfig="@xml/network_security_config"
       android:roundIcon="@drawable/ic_launcher_round"
       android:supportsRtl="true"

chrome/android/expectations/monochrome_public_bundle.proguard_flags.expected

@@ -250,6 +250,17 @@
 # and 53kb memory/process (through shrinking method/string counts).
 -repackageclasses ''
 
+# File: ../../chrome/android/proguard/isolated_splits.flags
+# Copyright 2020 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Isolated splits currently use DexSplitter for splitting out some DFMs.
+# DexSplitter has some issues with certain R8 optimizations, so we need to keep
+# ModuleInterface classes to make sure they aren't inlined.
+-keep @interface org.chromium.components.module_installer.builder.ModuleInterface
+-keep @org.chromium.components.module_installer.builder.ModuleInterface class ** {}
+
 # File: ../../chrome/android/proguard/main.flags
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be

chrome/android/expectations/trichrome_chrome_bundle.AndroidManifest.expected

 <?xml version="1.0" ?>
 <manifest
+    android:isolatedSplits="true"
     package="org.chromium.chrome.stable"
     platformBuildVersionCode="30"
     platformBuildVersionName="11"
@@ -72,13 +73,14 @@
   <application
       android:allowAudioPlaybackCapture="false"
       android:allowBackup="false"
+      android:appComponentFactory="org.chromium.chrome.browser.base.SplitCompatAppComponentFactory"
       android:extractNativeLibs="false"
       android:icon="@drawable/ic_launcher"
       android:label="@string/app_name"
       android:largeHeap="false"
       android:manageSpaceActivity="@string/manage_space_activity"
       android:multiArch="true"
-      android:name="org.chromium.chrome.browser.ChromeApplication"
+      android:name="org.chromium.chrome.browser.base.SplitChromeApplication"
       android:networkSecurityConfig="@xml/network_security_config"
       android:roundIcon="@drawable/ic_launcher_round"
       android:supportsRtl="true"

chrome/android/modules/buildflags.gni

@@ -11,10 +11,7 @@ declare_args() {
   # Whether //chrome code and resources are in a DFM for Monochrome and
   # Trichrome bundles. This module will also include code and resources from all
   # other DFMs.
-  # TODO(crbug.com/1126301): The binary size tools need to be updated to include
-  # DFM code before this can be enabled on stable.
-  enable_chrome_module = android_channel == "default" ||
-                         android_channel == "canary" || android_channel == "dev"
+  enable_chrome_module = true
 
   # Whether to enable DFMs which depend on the chrome DFM. These will be split
   # out of the chrome DFM using DexSplitter.