Commit 02355194 authored by sky's avatar sky Committed by Commit bot

Moves ash/wm/common/resources back to ash

We decided on a different approach that doesn't require splitting
these out.

This is a revert of https://codereview.chromium.org/1994993003 .

BUG=616265
TEST=none
R=oshima@chromium.org, thestig@chromium.org

Review-Url: https://codereview.chromium.org/2026973002
Cr-Commit-Position: refs/heads/master@{#397033}
parent 38186829
...@@ -24,7 +24,6 @@ component("ash") { ...@@ -24,7 +24,6 @@ component("ash") {
public_deps = [ public_deps = [
"//ash/resources", "//ash/resources",
"//ash/strings", "//ash/strings",
"//ash/wm/common/resources",
] ]
deps = [ deps = [
"//base", "//base",
...@@ -192,7 +191,6 @@ source_set("test_support") { ...@@ -192,7 +191,6 @@ source_set("test_support") {
deps = [ deps = [
":test_support_with_content", # TODO(beng): reverse this direction. ":test_support_with_content", # TODO(beng): reverse this direction.
"//ash/resources", "//ash/resources",
"//ash/wm/common/resources",
"//base:i18n", "//base:i18n",
"//base/test:test_support", "//base/test:test_support",
"//components/signin/core/account_id", "//components/signin/core/account_id",
...@@ -283,7 +281,6 @@ static_library("ash_shell_lib") { ...@@ -283,7 +281,6 @@ static_library("ash_shell_lib") {
":test_support", ":test_support",
"//ash/resources", "//ash/resources",
"//ash/strings", "//ash/strings",
"//ash/wm/common/resources",
"//base", "//base",
"//base:i18n", "//base:i18n",
"//components/user_manager", "//components/user_manager",
...@@ -351,7 +348,6 @@ test("ash_unittests") { ...@@ -351,7 +348,6 @@ test("ash_unittests") {
":test_support_with_content", ":test_support_with_content",
"//ash/resources", "//ash/resources",
"//ash/strings", "//ash/strings",
"//ash/wm/common/resources",
"//base", "//base",
"//base/test:test_support", "//base/test:test_support",
"//components/signin/core/account_id", "//components/signin/core/account_id",
......
...@@ -9,7 +9,6 @@ include_rules = [ ...@@ -9,7 +9,6 @@ include_rules = [
"+gpu/config", "+gpu/config",
"+grit/ash_resources.h", "+grit/ash_resources.h",
"+grit/ash_strings.h", "+grit/ash_strings.h",
"+grit/ash_wm_common_resources.h",
"+media", "+media",
"+skia/ext", "+skia/ext",
"+third_party/cros_system_api", "+third_party/cros_system_api",
......
...@@ -1069,7 +1069,6 @@ ...@@ -1069,7 +1069,6 @@
'../url/url.gyp:url_lib', '../url/url.gyp:url_lib',
'ash_resources.gyp:ash_resources', 'ash_resources.gyp:ash_resources',
'ash_strings.gyp:ash_strings', 'ash_strings.gyp:ash_strings',
'wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
], ],
'defines': [ 'defines': [
'ASH_IMPLEMENTATION', 'ASH_IMPLEMENTATION',
......
...@@ -32,7 +32,6 @@ ...@@ -32,7 +32,6 @@
'dependencies': [ 'dependencies': [
'<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources', '<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources',
'ash_resources', 'ash_resources',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
], ],
'actions': [ 'actions': [
{ {
...@@ -41,7 +40,6 @@ ...@@ -41,7 +40,6 @@
'pak_output': '<(PRODUCT_DIR)/ash_test_resources_100_percent.pak', 'pak_output': '<(PRODUCT_DIR)/ash_test_resources_100_percent.pak',
'pak_inputs': [ 'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_100_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ash/wm/common/resources/ash_wm_common_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ui/resources/webui_resources.pak', '<(SHARED_INTERMEDIATE_DIR)/ui/resources/webui_resources.pak',
], ],
...@@ -87,7 +85,6 @@ ...@@ -87,7 +85,6 @@
'dependencies': [ 'dependencies': [
'<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources', '<(DEPTH)/ui/resources/ui_resources.gyp:ui_resources',
'ash_resources', 'ash_resources',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
], ],
'actions': [ 'actions': [
{ {
...@@ -96,7 +93,6 @@ ...@@ -96,7 +93,6 @@
'pak_output': '<(PRODUCT_DIR)/ash_test_resources_200_percent.pak', 'pak_output': '<(PRODUCT_DIR)/ash_test_resources_200_percent.pak',
'pak_inputs': [ 'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_200_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_200_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ash/wm/common/resources/ash_wm_common_resources_200_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_200_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_resources_200_percent.pak',
], ],
'conditions': [ 'conditions': [
......
...@@ -27,7 +27,6 @@ template("ash_test_resources") { ...@@ -27,7 +27,6 @@ template("ash_test_resources") {
sources = [ sources = [
"$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak", "$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak",
"$root_gen_dir/ash/wm/common/resources/ash_wm_common_resources_${percent}_percent.pak",
"$root_gen_dir/ui/resources/ui_resources_${percent}_percent.pak", "$root_gen_dir/ui/resources/ui_resources_${percent}_percent.pak",
] ]
...@@ -39,8 +38,7 @@ template("ash_test_resources") { ...@@ -39,8 +38,7 @@ template("ash_test_resources") {
} }
deps = [ deps = [
":resources", "//ash/resources",
"//ash/wm/common/resources",
"//content:resources", "//content:resources",
"//ui/resources", "//ui/resources",
] ]
......
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
<!-- KEEP THESE IN ALPHABETICAL ORDER! DO NOT ADD TO RANDOM PLACES JUST <!-- KEEP THESE IN ALPHABETICAL ORDER! DO NOT ADD TO RANDOM PLACES JUST
BECAUSE YOUR RESOURCES ARE FUNCTIONALLY RELATED OR FALL UNDER THE BECAUSE YOUR RESOURCES ARE FUNCTIONALLY RELATED OR FALL UNDER THE
SAME CONDITIONALS. --> SAME CONDITIONALS. -->
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_BACKGROUND" file="common/shelf/shelf_background.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_CORNER" file="common/shelf/shelf_corner.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_CORNER" file="common/shelf/shelf_corner.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_DIMMING" file="common/shelf/shelf_dimming.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_DIMMING" file="common/shelf/shelf_dimming.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_APPLIST" file="common/shelf/status_launcher_menu_icon.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_APPLIST" file="common/shelf/status_launcher_menu_icon.png" />
...@@ -24,9 +25,20 @@ ...@@ -24,9 +25,20 @@
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_UNDERLINE_RUNNING" file="common/shelf/shelf_underline_running.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_UNDERLINE_RUNNING" file="common/shelf/shelf_underline_running.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_SETTINGS" file="common/shelf/settings_app_icon.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_SETTINGS" file="common/shelf/settings_app_icon.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_TASK_MANAGER" file="common/shelf/task_manager.png" /> <structure type="chrome_scaled_image" name="IDR_ASH_SHELF_ICON_TASK_MANAGER" file="common/shelf/task_manager.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_MULTI_WINDOW_RESIZE_H" file="common/multi_window_resize_horizontal.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_MULTI_WINDOW_RESIZE_V" file="common/multi_window_resize_vertical.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_NORMAL" file="common/shelf/status_icon_background_normal.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_NORMAL" file="common/shelf/status_icon_background_normal.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_ON_BLACK" file="common/shelf/status_icon_background_onblack_normal.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_ON_BLACK" file="common/shelf/status_icon_background_onblack_normal.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_PRESSED" file="common/shelf/status_icon_background_pressed.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_NOTIFICATION_BACKGROUND_PRESSED" file="common/shelf/status_icon_background_pressed.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_BOTTOM" file="common/phantom_window_bottom.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_BOTTOM_LEFT" file="common/phantom_window_bottom_left.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_BOTTOM_RIGHT" file="common/phantom_window_bottom_right.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_CENTER" file="common/phantom_window_center.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_LEFT" file="common/phantom_window_left.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_RIGHT" file="common/phantom_window_right.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_TOP" file="common/phantom_window_top.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_TOP_LEFT" file="common/phantom_window_top_left.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_PHANTOM_WINDOW_TOP_RIGHT" file="common/phantom_window_top_right.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM" file="common/resize_shadow_bottom.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM" file="common/resize_shadow_bottom.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM_LEFT" file="common/resize_shadow_bottom_left.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM_LEFT" file="common/resize_shadow_bottom_left.png" />
<structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM_RIGHT" file="common/resize_shadow_bottom_right.png" /> <structure type="chrome_scaled_image" name="IDR_AURA_RESIZE_SHADOW_BOTTOM_RIGHT" file="common/resize_shadow_bottom_right.png" />
......
...@@ -26,7 +26,6 @@ ...@@ -26,7 +26,6 @@
#include "ash/wm/window_properties.h" #include "ash/wm/window_properties.h"
#include "ash/wm/workspace_controller.h" #include "ash/wm/workspace_controller.h"
#include "grit/ash_resources.h" #include "grit/ash_resources.h"
#include "grit/ash_wm_common_resources.h"
#include "ui/aura/window.h" #include "ui/aura/window.h"
#include "ui/aura/window_event_dispatcher.h" #include "ui/aura/window_event_dispatcher.h"
#include "ui/aura/window_observer.h" #include "ui/aura/window_observer.h"
...@@ -453,7 +452,7 @@ void ShelfWidget::DelegateView::SetParentLayer(ui::Layer* layer) { ...@@ -453,7 +452,7 @@ void ShelfWidget::DelegateView::SetParentLayer(ui::Layer* layer) {
void ShelfWidget::DelegateView::OnPaintBackground(gfx::Canvas* canvas) { void ShelfWidget::DelegateView::OnPaintBackground(gfx::Canvas* canvas) {
ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance(); ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
gfx::ImageSkia shelf_background = gfx::ImageSkia shelf_background =
*rb->GetImageSkiaNamed(IDR_ASH_WM_COMMON_SHELF_BACKGROUND); *rb->GetImageSkiaNamed(IDR_ASH_SHELF_BACKGROUND);
const bool horizontal = wm::IsHorizontalAlignment(shelf_->GetAlignment()); const bool horizontal = wm::IsHorizontalAlignment(shelf_->GetAlignment());
if (!horizontal) { if (!horizontal) {
shelf_background = gfx::ImageSkiaOperations::CreateRotatedImage( shelf_background = gfx::ImageSkiaOperations::CreateRotatedImage(
......
...@@ -2,8 +2,6 @@ include_rules = [ ...@@ -2,8 +2,6 @@ include_rules = [
"-ash", "-ash",
"+ash/ash_export.h", "+ash/ash_export.h",
"+ash/wm/common", "+ash/wm/common",
"-grit/ash_resources.h",
"+grit/ash_wm_common_resources.h",
"+ui", "+ui",
"-ui/aura", "-ui/aura",
] ]
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
'target_name': 'ash_wm_common', 'target_name': 'ash_wm_common',
'type': '<(component)', 'type': '<(component)',
'dependencies': [ 'dependencies': [
'ash_wm_common_resources.gyp:ash_wm_common_resources',
'../../ash_resources.gyp:ash_resources', '../../ash_resources.gyp:ash_resources',
'../../../base/base.gyp:base', '../../../base/base.gyp:base',
'../../../skia/skia.gyp:skia', '../../../skia/skia.gyp:skia',
......
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'targets': [
{
# GN version: //ash/wm/common/resources
'target_name': 'ash_wm_common_resources',
'type': 'none',
'variables': {
'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/ash/wm/common/resources',
},
'actions': [
{
'action_name': 'ash_wm_common_resources',
'variables': {
'grit_grd_file': 'resources/ash_wm_common_resources.grd',
},
'includes': [ '../../../build/grit_action.gypi' ],
},
],
'includes': [ '../../../build/grit_target.gypi' ],
},
],
}
...@@ -18,7 +18,7 @@ ...@@ -18,7 +18,7 @@
#include "ash/wm/common/wm_window.h" #include "ash/wm/common/wm_window.h"
#include "base/auto_reset.h" #include "base/auto_reset.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "grit/ash_wm_common_resources.h" #include "grit/ash_resources.h"
#include "third_party/skia/include/core/SkColor.h" #include "third_party/skia/include/core/SkColor.h"
#include "third_party/skia/include/core/SkPaint.h" #include "third_party/skia/include/core/SkPaint.h"
#include "ui/base/resource/resource_bundle.h" #include "ui/base/resource/resource_bundle.h"
...@@ -143,7 +143,7 @@ class DockedBackgroundWidget : public views::Widget, ...@@ -143,7 +143,7 @@ class DockedBackgroundWidget : public views::Widget,
ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
gfx::ImageSkia shelf_background = gfx::ImageSkia shelf_background =
*rb.GetImageSkiaNamed(IDR_ASH_WM_COMMON_SHELF_BACKGROUND); *rb.GetImageSkiaNamed(IDR_ASH_SHELF_BACKGROUND);
shelf_background_left_ = gfx::ImageSkiaOperations::CreateRotatedImage( shelf_background_left_ = gfx::ImageSkiaOperations::CreateRotatedImage(
shelf_background, SkBitmapOperations::ROTATION_90_CW); shelf_background, SkBitmapOperations::ROTATION_90_CW);
shelf_background_right_ = gfx::ImageSkiaOperations::CreateRotatedImage( shelf_background_right_ = gfx::ImageSkiaOperations::CreateRotatedImage(
......
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//tools/grit/grit_rule.gni")
import("//tools/grit/repack.gni")
import("//ui/base/ui_features.gni")
assert(enable_hidpi)
grit("resources") {
source = "ash_wm_common_resources.grd"
outputs = [
"grit/ash_wm_common_resources.h",
"ash_wm_common_resources_100_percent.pak",
"ash_wm_common_resources_200_percent.pak",
]
}
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for Chromium Ash resources.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools, and see
http://www.chromium.org/developers/web-development-style-guide for the rules
we're checking against here.
"""
def CheckChangeOnUpload(input_api, output_api):
return _CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _CommonChecks(input_api, output_api)
def _CommonChecks(input_api, output_api):
"""Checks common to both upload and commit."""
results = []
resources = input_api.os_path.join(input_api.PresubmitLocalPath(),
'../../ui/resources')
# List of paths with their associated scale factor. This is used to verify
# that the images modified in one are the correct scale of the other.
path_scales = [
[(100, 'default_100_percent/'), (200, 'default_200_percent/')],
]
import sys
old_path = sys.path
try:
sys.path = [resources] + old_path
from resource_check import resource_scale_factors
for paths in path_scales:
results.extend(resource_scale_factors.ResourceScaleFactors(
input_api, output_api, paths).RunChecks())
finally:
sys.path = old_path
return results
<?xml version="1.0" encoding="UTF-8"?>
<grit latest_public_release="0" current_release="1">
<outputs>
<output filename="grit/ash_wm_common_resources.h" type="rc_header" context="default_100_percent">
<emit emit_type='prepend'></emit>
</output>
<output filename="ash_wm_common_resources_100_percent.pak" type="data_package" context="default_100_percent" />
<output filename="ash_wm_common_resources_200_percent.pak" type="data_package" context="default_200_percent" />
</outputs>
<release seq="1">
<structures fallback_to_low_resolution="true">
<!-- KEEP THESE IN ALPHABETICAL ORDER! DO NOT ADD TO RANDOM PLACES JUST
BECAUSE YOUR RESOURCES ARE FUNCTIONALLY RELATED OR FALL UNDER THE
SAME CONDITIONALS. -->
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_MULTI_WINDOW_RESIZE_H" file="common/multi_window_resize_horizontal.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_MULTI_WINDOW_RESIZE_V" file="common/multi_window_resize_vertical.png" />
<!-- TODO(sky): I suspect this one should be moved to a common
resources directory. -->
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_SHELF_BACKGROUND" file="common/shelf/shelf_background.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_BOTTOM" file="common/phantom_window_bottom.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_BOTTOM_LEFT" file="common/phantom_window_bottom_left.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_BOTTOM_RIGHT" file="common/phantom_window_bottom_right.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_CENTER" file="common/phantom_window_center.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_LEFT" file="common/phantom_window_left.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_RIGHT" file="common/phantom_window_right.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_TOP" file="common/phantom_window_top.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_TOP_LEFT" file="common/phantom_window_top_left.png" />
<structure type="chrome_scaled_image" name="IDR_ASH_WM_COMMON_PHANTOM_WINDOW_TOP_RIGHT" file="common/phantom_window_top_right.png" />
</structures>
</release>
</grit>
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
#include "ash/wm/common/wm_shell_window_ids.h" #include "ash/wm/common/wm_shell_window_ids.h"
#include "ash/wm/common/wm_window.h" #include "ash/wm/common/wm_window.h"
#include "ash/wm/common/workspace/workspace_window_resizer.h" #include "ash/wm/common/workspace/workspace_window_resizer.h"
#include "grit/ash_wm_common_resources.h" #include "grit/ash_resources.h"
#include "ui/base/cursor/cursor.h" #include "ui/base/cursor/cursor.h"
#include "ui/base/hit_test.h" #include "ui/base/hit_test.h"
#include "ui/base/resource/resource_bundle.h" #include "ui/base/resource/resource_bundle.h"
...@@ -67,9 +67,8 @@ class MultiWindowResizeController::ResizeView : public views::View { ...@@ -67,9 +67,8 @@ class MultiWindowResizeController::ResizeView : public views::View {
Direction direction) Direction direction)
: controller_(controller), direction_(direction), image_(NULL) { : controller_(controller), direction_(direction), image_(NULL) {
ResourceBundle& rb = ResourceBundle::GetSharedInstance(); ResourceBundle& rb = ResourceBundle::GetSharedInstance();
int image_id = direction == TOP_BOTTOM int image_id = direction == TOP_BOTTOM ? IDR_AURA_MULTI_WINDOW_RESIZE_H
? IDR_ASH_WM_COMMON_MULTI_WINDOW_RESIZE_H : IDR_AURA_MULTI_WINDOW_RESIZE_V;
: IDR_ASH_WM_COMMON_MULTI_WINDOW_RESIZE_V;
image_ = rb.GetImageNamed(image_id).ToImageSkia(); image_ = rb.GetImageNamed(image_id).ToImageSkia();
} }
......
...@@ -11,7 +11,7 @@ ...@@ -11,7 +11,7 @@
#include "ash/wm/common/wm_root_window_controller.h" #include "ash/wm/common/wm_root_window_controller.h"
#include "ash/wm/common/wm_shell_window_ids.h" #include "ash/wm/common/wm_shell_window_ids.h"
#include "ash/wm/common/wm_window.h" #include "ash/wm/common/wm_window.h"
#include "grit/ash_wm_common_resources.h" #include "grit/ash_resources.h"
#include "ui/compositor/layer.h" #include "ui/compositor/layer.h"
#include "ui/compositor/scoped_layer_animation_settings.h" #include "ui/compositor/scoped_layer_animation_settings.h"
#include "ui/views/background.h" #include "ui/views/background.h"
...@@ -34,8 +34,7 @@ const float kStartBoundsRatio = 0.85f; ...@@ -34,8 +34,7 @@ const float kStartBoundsRatio = 0.85f;
const int kShadowThickness = 15; const int kShadowThickness = 15;
// The minimum size of a phantom window including the shadow. The minimum size // The minimum size of a phantom window including the shadow. The minimum size
// is derived from the size of the IDR_ASH_WM_COMMON_PHANTOM_WINDOW image // is derived from the size of the IDR_AURA_PHANTOM_WINDOW image assets.
// assets.
const int kMinSizeWithShadow = 100; const int kMinSizeWithShadow = 100;
// Adjusts the phantom window's bounds so that the bounds: // Adjusts the phantom window's bounds so that the bounds:
...@@ -133,7 +132,7 @@ std::unique_ptr<views::Widget> PhantomWindowController::CreatePhantomWidget( ...@@ -133,7 +132,7 @@ std::unique_ptr<views::Widget> PhantomWindowController::CreatePhantomWidget(
window_); window_);
} }
const int kImages[] = IMAGE_GRID(IDR_ASH_WM_COMMON_PHANTOM_WINDOW); const int kImages[] = IMAGE_GRID(IDR_AURA_PHANTOM_WINDOW);
views::Painter* background_painter = views::Painter* background_painter =
views::Painter::CreateImageGridPainter(kImages); views::Painter::CreateImageGridPainter(kImages);
views::View* content_view = new views::View; views::View* content_view = new views::View;
......
...@@ -1299,14 +1299,9 @@ template("chrome_repack_percent") { ...@@ -1299,14 +1299,9 @@ template("chrome_repack_percent") {
] ]
} }
if (use_ash) { if (use_ash) {
sources += [ sources +=
"$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak", [ "$root_gen_dir/ash/resources/ash_resources_${percent}_percent.pak" ]
"$root_gen_dir/ash/wm/common/resources/ash_wm_common_resources_${percent}_percent.pak", deps += [ "//ash/resources" ]
]
deps += [
"//ash/resources",
"//ash/wm/common/resources",
]
} }
if (toolkit_views) { if (toolkit_views) {
sources += [ "$root_gen_dir/ui/views/resources/views_resources_${percent}_percent.pak" ] sources += [ "$root_gen_dir/ui/views/resources/views_resources_${percent}_percent.pak" ]
......
...@@ -10,6 +10,7 @@ source_set("mash") { ...@@ -10,6 +10,7 @@ source_set("mash") {
"mash_runner.h", "mash_runner.h",
] ]
deps = [ deps = [
"//ash/resources",
"//ash/sysui:lib", "//ash/sysui:lib",
"//base:i18n", "//base:i18n",
"//components/mus:lib", "//components/mus:lib",
......
...@@ -23,7 +23,6 @@ source_set("chromeos") { ...@@ -23,7 +23,6 @@ source_set("chromeos") {
public_deps = [ public_deps = [
"//ash/resources", "//ash/resources",
"//ash/strings", "//ash/strings",
"//ash/wm/common/resources",
"//chrome:extra_resources", "//chrome:extra_resources",
"//chrome:resources", "//chrome:resources",
"//chrome:strings", "//chrome:strings",
...@@ -193,7 +192,6 @@ source_set("unit_tests") { ...@@ -193,7 +192,6 @@ source_set("unit_tests") {
":attestation_proto", ":attestation_proto",
":device_policy_proto", ":device_policy_proto",
"//ash/resources", "//ash/resources",
"//ash/wm/common/resources",
"//components/drive", "//components/drive",
"//components/drive:test_support_chromeos", "//components/drive:test_support_chromeos",
"//components/invalidation/public", "//components/invalidation/public",
......
...@@ -359,7 +359,6 @@ source_set("ui") { ...@@ -359,7 +359,6 @@ source_set("ui") {
deps += [ deps += [
# aura uses some of ash resources. # aura uses some of ash resources.
"//ash/resources", "//ash/resources",
"//ash/wm/common/resources",
"//ui/aura", "//ui/aura",
"//ui/keyboard", "//ui/keyboard",
"//ui/keyboard:keyboard_with_content", "//ui/keyboard:keyboard_with_content",
......
...@@ -1280,7 +1280,6 @@ ...@@ -1280,7 +1280,6 @@
'../ash/ash.gyp:ash_with_content', '../ash/ash.gyp:ash_with_content',
'../ash/ash_resources.gyp:ash_resources', '../ash/ash_resources.gyp:ash_resources',
'../ash/ash_strings.gyp:ash_strings', '../ash/ash_strings.gyp:ash_strings',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
'../components/components.gyp:session_manager_component', '../components/components.gyp:session_manager_component',
'../components/components.gyp:user_manager', '../components/components.gyp:user_manager',
'../ui/app_list/app_list.gyp:app_list', '../ui/app_list/app_list.gyp:app_list',
......
...@@ -3063,7 +3063,6 @@ ...@@ -3063,7 +3063,6 @@
'dependencies': [ 'dependencies': [
# aura uses some of ash resources. # aura uses some of ash resources.
'../ash/ash_resources.gyp:ash_resources', '../ash/ash_resources.gyp:ash_resources',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
'../ui/aura/aura.gyp:aura', '../ui/aura/aura.gyp:aura',
'../ui/keyboard/keyboard.gyp:keyboard', '../ui/keyboard/keyboard.gyp:keyboard',
'../ui/keyboard/keyboard.gyp:keyboard_with_content', '../ui/keyboard/keyboard.gyp:keyboard_with_content',
......
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
['use_ash==1', { ['use_ash==1', {
'pak_inputs': [ 'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_100_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_100_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ash/wm/common/resources/ash_wm_common_resources_100_percent.pak',
], ],
}], }],
['chromeos==1', { ['chromeos==1', {
......
...@@ -27,7 +27,6 @@ ...@@ -27,7 +27,6 @@
['use_ash==1', { ['use_ash==1', {
'pak_inputs': [ 'pak_inputs': [
'<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_200_percent.pak', '<(SHARED_INTERMEDIATE_DIR)/ash/resources/ash_resources_200_percent.pak',
'<(SHARED_INTERMEDIATE_DIR)/ash/wm/common/resources/ash_wm_common_resources_200_percent.pak',
], ],
}], }],
['chromeos==1', { ['chromeos==1', {
......
...@@ -567,7 +567,6 @@ ...@@ -567,7 +567,6 @@
'dependencies': [ # Update duplicate logic in repack_locales.py 'dependencies': [ # Update duplicate logic in repack_locales.py
'<(DEPTH)/ash/ash_resources.gyp:ash_resources', '<(DEPTH)/ash/ash_resources.gyp:ash_resources',
'<(DEPTH)/ash/ash_strings.gyp:ash_strings', '<(DEPTH)/ash/ash_strings.gyp:ash_strings',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
], ],
}], }],
['toolkit_views==1', { ['toolkit_views==1', {
......
...@@ -1818,7 +1818,6 @@ ...@@ -1818,7 +1818,6 @@
['chromeos==1', { ['chromeos==1', {
'dependencies': [ 'dependencies': [
'../ash/ash_resources.gyp:ash_resources', '../ash/ash_resources.gyp:ash_resources',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
'../chromeos/chromeos.gyp:chromeos', '../chromeos/chromeos.gyp:chromeos',
], ],
'conditions': [ 'conditions': [
......
...@@ -2415,7 +2415,6 @@ ...@@ -2415,7 +2415,6 @@
'../ash/ash.gyp:ash_test_support', '../ash/ash.gyp:ash_test_support',
'../ash/ash_resources.gyp:ash_resources', '../ash/ash_resources.gyp:ash_resources',
'../ash/ash_strings.gyp:ash_strings', '../ash/ash_strings.gyp:ash_strings',
'../ash/wm/common/ash_wm_common_resources.gyp:ash_wm_common_resources',
], ],
# We eventually want to compile both in Win Aura builds, see # We eventually want to compile both in Win Aura builds, see
# http://crbug.com/155545. # http://crbug.com/155545.
......
...@@ -469,7 +469,6 @@ if (!is_android) { ...@@ -469,7 +469,6 @@ if (!is_android) {
deps += [ deps += [
"//ash/resources", "//ash/resources",
"//ash/wm/common/resources",
"//chromeos", "//chromeos",
] ]
...@@ -1882,7 +1881,6 @@ test("unit_tests") { ...@@ -1882,7 +1881,6 @@ test("unit_tests") {
"//ash:test_support", "//ash:test_support",
"//ash/resources", "//ash/resources",
"//ash/strings", "//ash/strings",
"//ash/wm/common/resources",
] ]
# We eventually want to compile both in Win Aura builds, see # We eventually want to compile both in Win Aura builds, see
......
...@@ -137,7 +137,6 @@ mojo_application_manifest("manifest") { ...@@ -137,7 +137,6 @@ mojo_application_manifest("manifest") {
repack("resources") { repack("resources") {
sources = [ sources = [
"$root_gen_dir/ash/wm/common/resources/ash_wm_common_resources_100_percent.pak",
"$root_gen_dir/mash/wm/resources/mash_wm_resources_100_percent.pak", "$root_gen_dir/mash/wm/resources/mash_wm_resources_100_percent.pak",
"$root_gen_dir/ui/resources/ui_resources_100_percent.pak", "$root_gen_dir/ui/resources/ui_resources_100_percent.pak",
"$root_gen_dir/ui/strings/app_locale_settings_en-US.pak", "$root_gen_dir/ui/strings/app_locale_settings_en-US.pak",
...@@ -146,7 +145,6 @@ repack("resources") { ...@@ -146,7 +145,6 @@ repack("resources") {
] ]
output = "$root_out_dir/mash_wm_resources.pak" output = "$root_out_dir/mash_wm_resources.pak"
deps = [ deps = [
"//ash/wm/common/resources",
"//mash/wm/resources", "//mash/wm/resources",
"//ui/resources", "//ui/resources",
"//ui/strings", "//ui/strings",
......
...@@ -64,9 +64,6 @@ ...@@ -64,9 +64,6 @@
"includes": [6100], "includes": [6100],
"structures": [6150], "structures": [6150],
}, },
"ash/wm/common/resources/ash_wm_common_resources.grd": {
"structures": [6700],
},
"ui/keyboard/keyboard_resources.grd": { "ui/keyboard/keyboard_resources.grd": {
"includes": [6850], "includes": [6850],
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment