Commit 025b7ade authored by Sven Zheng's avatar Sven Zheng Committed by Chromium LUCI CQ

Disable IncognitoCommandsApiTest.IncognitoMode test

This test is flaky only on Lacros. Disable it first.

Bug: 1154365
Change-Id: Ie0b5db5f1c6ba2652e359769108262163750c7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593216Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#837468}
parent e4a08a4e
...@@ -1017,8 +1017,14 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, TabParameter) { ...@@ -1017,8 +1017,14 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, TabParameter) {
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
} }
// Disable this test only for Lacros due to flakiness. crbug.com/1154365.
#if BUILDFLAG(IS_CHROMEOS_LACROS)
#define MAYBE_IncognitoMode DISABLED_IncognitoMode
#else
#define MAYBE_IncognitoMode IncognitoMode
#endif
// Test Keybinding in incognito mode. // Test Keybinding in incognito mode.
IN_PROC_BROWSER_TEST_P(IncognitoCommandsApiTest, IncognitoMode) { IN_PROC_BROWSER_TEST_P(IncognitoCommandsApiTest, MAYBE_IncognitoMode) {
ASSERT_TRUE(embedded_test_server()->Start()); ASSERT_TRUE(embedded_test_server()->Start());
bool is_incognito_enabled = GetParam(); bool is_incognito_enabled = GetParam();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment