Skip to content

GitLab

T
tangled
Commit 0260a831 authored by Daniel Rubery's avatar Daniel Rubery Committed by Commit Bot
Browse files
Options

Add browser test for iframe created and added to DOM. 

This was used to evade referrer chain attribution. However, the problem
was already fixed at HEAD by the time we discovered what was wrong, so
this CL just adds a browser test to ensure that we don't regress.

Change-Id: I69b3189a873288509fb8bdad02c248598819e07c
Reviewed-on: https://chromium-review.googlesource.com/1256105
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: default avatarJialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595682}
parent 8273db87
Hide whitespace changes
Inline Side-by-side
Showing with 37 additions and 0 deletions
chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc
View file @ 0260a831
...@@ -83,6 +83,9 @@ const char kLandingReferrerURLWithQuery[] = ...@@ -83,6 +83,9 @@ const char kLandingReferrerURLWithQuery[] =
const char kPageBeforeLandingReferrerURL[] = const char kPageBeforeLandingReferrerURL[] =
"/safe_browsing/download_protection/navigation_observer/" "/safe_browsing/download_protection/navigation_observer/"
"page_before_landing_referrer.html"; "page_before_landing_referrer.html";
const char kCreateIframeElementURL[] =
"/safe_browsing/download_protection/navigation_observer/"
"create_iframe_element.html";
class DownloadItemCreatedObserver : public DownloadManager::Observer { class DownloadItemCreatedObserver : public DownloadManager::Observer {
public: public:
...@@ -2492,4 +2495,15 @@ IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest, ReloadNotRecorded) { ...@@ -2492,4 +2495,15 @@ IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest, ReloadNotRecorded) {
EXPECT_EQ(1U, nav_list->Size()); EXPECT_EQ(1U, nav_list->Size());
} }
IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
CreateIframeElementGetsReferrerChain) {
GURL initial_url = embedded_test_server()->GetURL(kCreateIframeElementURL);
ui_test_utils::NavigateToURL(browser(), initial_url);
ClickTestLink("do_download", 1, initial_url);
ReferrerChain referrer_chain;
IdentifyReferrerChainForDownload(GetDownload(), &referrer_chain);
ASSERT_EQ(2, referrer_chain.size());
}
} // namespace safe_browsing } // namespace safe_browsing
chrome/test/data/safe_browsing/download_protection/navigation_observer/create_iframe_element.html 0 → 100644
View file @ 0260a831
<html>
<head>
<script>
function clickLink(linkId) {
var node = document.getElementById(linkId);
if (node != null) {
// Click and open link in the same tab.
node.click();
}
}
function runTest() {
var download_url = "../signed.exe";
var ifrm = document.createElement("iframe");
ifrm.setAttribute("src", download_url);
document.body.appendChild(ifrm);
}
</script>
</head>
<body>
<a id="do_download" onclick="runTest()">Click for download</div>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment