Don't remove extension with damaged file from ExternalCacheImpl's input
ExternalCacheImpl's |extensions| reflects the "input" of which extensions it should try to load + cache. |cached_extensions_| reflects the "output" of which extensions are currently cached. When a damaged file is detected, that file + extension should be removed from the cache, which means that it should *only* be removed from |cached_extensions_|, not from |extensions_|. Also removing the extension entry from |extensions_| will result in ExternalCacheImpl's IsExtensionPending() returning an invalid result. Bug: 1115905 Change-Id: I4ca82caf3d27d65a31ba481a0320c273d80b2655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362906Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#801084}
Showing
Please register or sign in to comment