Commit 02896532 authored by Kenichi Ishibashi's avatar Kenichi Ishibashi Committed by Commit Bot

service worker: Fix navigation-preload/resource-timing.https.html test

Before this CL, this test tried to get performance entries right after
Response#text() is resolved, but Chrome doesn't guarantee that there
will be a performance entry for the response at that point. This CL
changes the test to use PerformanceObserver so that we can make sure
that there will be a performance entry for the response.

Bug: 872078
Change-Id: I6ecfcb8e0721df541d5a32f56ec4c062efbffdae
Reviewed-on: https://chromium-review.googlesource.com/1170679
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583483}
parent 2476e6fb
async function wait_for_performance_entries(url) {
let entries = performance.getEntriesByName(url);
if (entries.length > 0) {
return entries;
}
return new Promise((resolve) => {
new PerformanceObserver((list) => {
const entries = list.getEntriesByName(url);
if (entries.length > 0) {
resolve(entries);
}
}).observe({ entryTypes: ['resource'] });
});
}
self.addEventListener('activate', event => { self.addEventListener('activate', event => {
event.waitUntil(self.registration.navigationPreload.enable()); event.waitUntil(self.registration.navigationPreload.enable());
}); });
self.addEventListener('fetch', event => { self.addEventListener('fetch', event => {
let headers;
event.respondWith( event.respondWith(
event.preloadResponse event.preloadResponse
.then(response => { .then(response => {
var headers = response.headers; headers = response.headers;
return response.text().then(text => return response.text()
new Response( })
JSON.stringify({ .then(_ => wait_for_performance_entries(event.request.url))
decodedBodySize: headers.get('X-Decoded-Body-Size'), .then(entries =>
encodedBodySize: headers.get('X-Encoded-Body-Size'), new Response(
timingEntries: performance.getEntriesByName(event.request.url) JSON.stringify({
}), decodedBodySize: headers.get('X-Decoded-Body-Size'),
{headers: {'Content-Type': 'text/html'}})); encodedBodySize: headers.get('X-Encoded-Body-Size'),
})); timingEntries: entries
}),
{headers: {'Content-Type': 'text/html'}})));
}); });
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment