Remove some incorrect/obsolete reference to AsyncExtensionFunction.

ChromeAsyncExtensionFunction does not derive from
AsyncExtensionFunction, update such references, mostly in comments.

Bug: 829174
Change-Id: Ic48ec85540f00660ecbb58899d501152c1117341
Reviewed-on: https://chromium-review.googlesource.com/1001772
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549351}

chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.h

@@ -107,7 +107,7 @@ class FileBrowserHandlerInternalSelectFileFunction
   // The class is ref counted, so destructor should not be public.
   ~FileBrowserHandlerInternalSelectFileFunction() override;
 
-  // AsyncExtensionFunction implementation.
+  // ChromeAsyncExtensionFunction implementation.
   // Runs the extension function implementation.
   bool RunAsync() override;
 

chrome/browser/chromeos/extensions/file_manager/private_api_base.h

@@ -12,7 +12,7 @@
 
 namespace extensions {
 
-// This class adds a logging feature to AsyncExtensionFunction. Logging is
+// This class adds a logging feature to ChromeAsyncExtensionFunction. Logging is
 // done when sending the response to JavaScript, using drive::util::Log().
 // Async API functions of fileManagerPrivate should inherit this class.
 //
@@ -27,7 +27,7 @@ class LoggedAsyncExtensionFunction : public ChromeAsyncExtensionFunction {
  protected:
   ~LoggedAsyncExtensionFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   void OnResponded() override;
 
   // Sets the logging on completion flag. By default, logging is turned off.

chrome/browser/chromeos/extensions/file_manager/private_api_dialog.h

@@ -28,7 +28,7 @@ class FileManagerPrivateCancelDialogFunction
  protected:
   ~FileManagerPrivateCancelDialogFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -41,7 +41,7 @@ class FileManagerPrivateSelectFileFunction
  protected:
   ~FileManagerPrivateSelectFileFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -61,7 +61,7 @@ class FileManagerPrivateSelectFilesFunction
  protected:
   ~FileManagerPrivateSelectFilesFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:

chrome/browser/chromeos/extensions/file_manager/private_api_drive.h

@@ -70,7 +70,7 @@ class FileManagerPrivateInternalGetEntryPropertiesFunction
  protected:
   ~FileManagerPrivateInternalGetEntryPropertiesFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -94,7 +94,7 @@ class FileManagerPrivateInternalPinDriveFileFunction
  protected:
   ~FileManagerPrivateInternalPinDriveFileFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -112,7 +112,7 @@ class FileManagerPrivateInternalCancelFileTransfersFunction
  protected:
   ~FileManagerPrivateInternalCancelFileTransfersFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -126,7 +126,7 @@ class FileManagerPrivateCancelAllFileTransfersFunction
  protected:
   ~FileManagerPrivateCancelAllFileTransfersFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -211,7 +211,7 @@ class FileManagerPrivateRequestAccessTokenFunction
  protected:
   ~FileManagerPrivateRequestAccessTokenFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   // Callback with a cached auth token (if available) or a fetched one.
@@ -229,7 +229,7 @@ class FileManagerPrivateInternalGetShareUrlFunction
  protected:
   ~FileManagerPrivateInternalGetShareUrlFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   // Callback with an url to the sharing dialog as |share_url|, called by
@@ -265,7 +265,7 @@ class FileManagerPrivateInternalGetDownloadUrlFunction
  protected:
   ~FileManagerPrivateInternalGetDownloadUrlFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   void OnGetResourceEntry(drive::FileError error,

chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h

@@ -112,7 +112,7 @@ class FileWatchFunctionBase : public LoggedAsyncExtensionFunction {
       const storage::FileSystemURL& file_system_url,
       base::WeakPtr<file_manager::EventRouter> event_router) = 0;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -177,7 +177,7 @@ class FileManagerPrivateGetSizeStatsFunction
  protected:
   ~FileManagerPrivateGetSizeStatsFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -206,7 +206,7 @@ class FileManagerPrivateInternalValidatePathNameLengthFunction
 
   void OnFilePathLimitRetrieved(size_t current_length, size_t max_length);
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -221,7 +221,7 @@ class FileManagerPrivateFormatVolumeFunction
  protected:
   ~FileManagerPrivateFormatVolumeFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -236,7 +236,7 @@ class FileManagerPrivateRenameVolumeFunction
  protected:
   ~FileManagerPrivateRenameVolumeFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -250,7 +250,7 @@ class FileManagerPrivateInternalStartCopyFunction
  protected:
   ~FileManagerPrivateInternalStartCopyFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -278,7 +278,7 @@ class FileManagerPrivateCancelCopyFunction
  protected:
   ~FileManagerPrivateCancelCopyFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -294,7 +294,7 @@ class FileManagerPrivateInternalResolveIsolatedEntriesFunction
  protected:
   ~FileManagerPrivateInternalResolveIsolatedEntriesFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -314,7 +314,7 @@ class FileManagerPrivateInternalComputeChecksumFunction
  protected:
   ~FileManagerPrivateInternalComputeChecksumFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -334,7 +334,7 @@ class FileManagerPrivateSearchFilesByHashesFunction
   ~FileManagerPrivateSearchFilesByHashesFunction() override {}
 
  private:
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   // Sends a response with |results| to the extension.
@@ -390,7 +390,7 @@ class FileManagerPrivateInternalGetDirectorySizeFunction
 
   void OnDirectorySizeRetrieved(int64_t size);
 
-  // AsyncExtensionFunction overrides
+  // ChromeAsyncExtensionFunction overrides
   bool RunAsync() override;
 };
 

chrome/browser/chromeos/extensions/file_manager/private_api_misc.h

@@ -95,7 +95,7 @@ class FileManagerPrivateInternalZipSelectionFunction
  protected:
   ~FileManagerPrivateInternalZipSelectionFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   // Receives the result from ZipFileCreator.
@@ -129,6 +129,8 @@ class FileManagerPrivateRequestWebStoreAccessTokenFunction
 
  protected:
   ~FileManagerPrivateRequestWebStoreAccessTokenFunction() override;
+
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -175,7 +177,7 @@ class FileManagerPrivateInternalGetMimeTypeFunction
  protected:
   ~FileManagerPrivateInternalGetMimeTypeFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
   void OnGetMimeType(const std::string& mimeType);

chrome/browser/chromeos/extensions/file_manager/private_api_mount.h

@@ -26,7 +26,7 @@ class FileManagerPrivateAddMountFunction : public LoggedAsyncExtensionFunction {
  protected:
   ~FileManagerPrivateAddMountFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -61,7 +61,7 @@ class FileManagerPrivateRemoveMountFunction
  protected:
   ~FileManagerPrivateRemoveMountFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 
@@ -76,7 +76,7 @@ class FileManagerPrivateMarkCacheAsMountedFunction
  protected:
   ~FileManagerPrivateMarkCacheAsMountedFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -105,7 +105,7 @@ class FileManagerPrivateGetVolumeMetadataListFunction
  protected:
   ~FileManagerPrivateGetVolumeMetadataListFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 };
 

chrome/browser/chromeos/extensions/file_manager/private_api_tasks.h

@@ -36,7 +36,7 @@ class FileManagerPrivateInternalExecuteTaskFunction
  protected:
   ~FileManagerPrivateInternalExecuteTaskFunction() override {}
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:
@@ -56,7 +56,7 @@ class FileManagerPrivateInternalGetFileTasksFunction
  protected:
   ~FileManagerPrivateInternalGetFileTasksFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // ChromeAsyncExtensionFunction overrides.
   bool RunAsync() override;
 
  private:

chrome/browser/chromeos/extensions/users_private/users_private_api.h

@@ -45,7 +45,7 @@ class UsersPrivateAddWhitelistedUserFunction
  protected:
   ~UsersPrivateAddWhitelistedUserFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
  private:

chrome/browser/extensions/api/bookmarks/bookmarks_api.h

@@ -126,7 +126,7 @@ class BookmarksAPI : public BrowserContextKeyedAPI,
 class BookmarksFunction : public ChromeAsyncExtensionFunction,
                           public bookmarks::BaseBookmarkModelObserver {
  public:
-  // AsyncExtensionFunction:
+  // ChromeAsyncExtensionFunction:
   bool RunAsync() override;
 
  protected:

chrome/browser/extensions/api/data_reduction_proxy/data_reduction_proxy_api.cc

@@ -16,7 +16,7 @@
 
 namespace extensions {
 
-AsyncExtensionFunction::ResponseAction
+ExtensionFunction::ResponseAction
 DataReductionProxyClearDataSavingsFunction::Run() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   data_reduction_proxy::DataReductionProxySettings* settings =
@@ -27,7 +27,7 @@ DataReductionProxyClearDataSavingsFunction::Run() {
   return RespondNow(NoArguments());
 }
 
-AsyncExtensionFunction::ResponseAction
+ExtensionFunction::ResponseAction
 DataReductionProxyGetDataUsageFunction::Run() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   data_reduction_proxy::DataReductionProxySettings* settings =

chrome/browser/extensions/api/settings_private/settings_private_api.h

@@ -22,7 +22,7 @@ class SettingsPrivateSetPrefFunction : public UIThreadExtensionFunction {
  protected:
   ~SettingsPrivateSetPrefFunction() override;
 
-  // ExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsPrivateSetPrefFunction);
@@ -38,7 +38,7 @@ class SettingsPrivateGetAllPrefsFunction : public UIThreadExtensionFunction {
  protected:
   ~SettingsPrivateGetAllPrefsFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsPrivateGetAllPrefsFunction);
@@ -54,7 +54,7 @@ class SettingsPrivateGetPrefFunction : public UIThreadExtensionFunction {
  protected:
   ~SettingsPrivateGetPrefFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsPrivateGetPrefFunction);
@@ -71,7 +71,7 @@ class SettingsPrivateGetDefaultZoomFunction
  protected:
   ~SettingsPrivateGetDefaultZoomFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsPrivateGetDefaultZoomFunction);
@@ -88,7 +88,7 @@ class SettingsPrivateSetDefaultZoomFunction
  protected:
   ~SettingsPrivateSetDefaultZoomFunction() override;
 
-  // AsyncExtensionFunction overrides.
+  // UIThreadExtensionFunction overrides.
   ResponseAction Run() override;
 
   DISALLOW_COPY_AND_ASSIGN(SettingsPrivateSetDefaultZoomFunction);

extensions/browser/api/feedback_private/feedback_private_api.cc

@@ -347,7 +347,7 @@ void FeedbackPrivateSendFeedbackFunction::OnCompleted(
   }
 }
 
-AsyncExtensionFunction::ResponseAction
+ExtensionFunction::ResponseAction
 FeedbackPrivateLogSrtPromptResultFunction::Run() {
   std::unique_ptr<feedback_private::LogSrtPromptResult::Params> params(
       feedback_private::LogSrtPromptResult::Params::Create(*args_));

extensions/browser/api/feedback_private/feedback_private_api.h

@@ -144,7 +144,7 @@ class FeedbackPrivateLogSrtPromptResultFunction
 
  protected:
   ~FeedbackPrivateLogSrtPromptResultFunction() override {}
-  AsyncExtensionFunction::ResponseAction Run() override;
+  ResponseAction Run() override;
 };
 
 }  // namespace extensions