Commit 02b0411a authored by Wez's avatar Wez Committed by Commit Bot

[fuchsia] Add //fuchsia/SECURITY_OWNERS and per-file OWNERS using it.

Add a set of owners for Fuchsia-specific security reviews, which will
apply to CLs which have:
- Changes to Chromium-defined FIDL APIs.
- Changes to component sandbox specifications.
- Changes to critical integration code, e.g. the sandbox policy.

The new //fuchsia/SECURITY_OWNERS file is applied to specific files in
//base, //fuchsia and //services, that are critical to the security of
WebEngine and other Chromium packages published for use on Fuchsia.

Bug: 1053551
Change-Id: I809cc07843ff06167b596f3fea21307e599803bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128079Reviewed-by: default avatarDavid Dorwin <ddorwin@chromium.org>
Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758932}
parent 0ae48f44
# LaunchProcess() is part of the Fuchsia sandbox.
per-file launch_fuchsia.*=set noparent
per-file launch_fuchsia.*=file://fuchsia/SECURITY_OWNERS
...@@ -10,6 +10,7 @@ file://third_party/OWNERS ...@@ -10,6 +10,7 @@ file://third_party/OWNERS
# Security reviews # Security reviews
file://chromeos/SECURITY_OWNERS file://chromeos/SECURITY_OWNERS
file://content/browser/SITE_ISOLATION_OWNERS file://content/browser/SITE_ISOLATION_OWNERS
file://fuchsia/SECURITY_OWNERS
file://ipc/SECURITY_OWNERS file://ipc/SECURITY_OWNERS
file://net/base/SECURITY_OWNERS file://net/base/SECURITY_OWNERS
file://sandbox/linux/OWNERS file://sandbox/linux/OWNERS
......
file://build/fuchsia/OWNERS file://build/fuchsia/OWNERS
per-file SECURITY_OWNERS=set noparent
per-file SECURITY_OWNERS=file://fuchsia/SECURITY_OWNERS
# COMPONENT: Fuchsia # COMPONENT: Fuchsia
# OS: Fuchsia # OS: Fuchsia
# TEAM: cr-fuchsia@chromium.org # TEAM: cr-fuchsia@chromium.org
# Changes to integration with the Fuchsia platform, or peer components, require
# security review to avoid introducing sandbox escapes. These include:
# - Critical platform integrations (e.g. shared memory, process launching).
# - Changes to Chromium-defined Fuchsia IPC (aka FIDL) protocols.
# - Addition of new FIDL services to child process sandboxes.
# - Addition of new FIDL clients and implementations.
#
# Security team: If you are uncomfortable reviewing a particular bit of code
# yourself, don't hesitate to seek help from another security team member!
# Nobody knows everything, and the only way to learn is from experience.
# Please keep reviewers ordered alphabetically by LDAP.
ajgo@chromium.org
rsesek@chromium.org
tsepez@chromium.org
wez@chromium.org
...@@ -3,6 +3,10 @@ per-file *.mojom=file://ipc/SECURITY_OWNERS ...@@ -3,6 +3,10 @@ per-file *.mojom=file://ipc/SECURITY_OWNERS
per-file *_type_converter*.*=set noparent per-file *_type_converter*.*=set noparent
per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS per-file *_type_converter*.*=file://ipc/SECURITY_OWNERS
# For security review. # For Mojo/IPC security review.
per-file web_engine_browser_interface_binders.*=set noparent per-file web_engine_browser_interface_binders.*=set noparent
per-file web_engine_browser_interface_binders.*=file://ipc/SECURITY_OWNERS per-file web_engine_browser_interface_binders.*=file://ipc/SECURITY_OWNERS
# For sandbox security review.
per-file context_provider_impl.*=set noparent
per-file context_provider_impl.*=file://fuchsia/SECURITY_OWNERS
file://build/fuchsia/OWNERS file://fuchsia/SECURITY_OWNERS
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment