Skip to content

GitLab

T
tangled
Commit 02c36253 authored by Jacob DeWitt's avatar Jacob DeWitt Committed by Commit Bot
Browse files
Options

Split ref space reset test for immersive vs inline sessions 

The immersive version of this test consistently passes, but the inline
version consistently times out on some bots, especially mac ones. Split
the test into separate files for the two session types so that we can
run the more important immersive test while we try to fix the inline
test (which is lower-priority).

Bug: 1013444
Change-Id: Ia0f021c8d1d482385218c4dfd66ee3d8cbc94c26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865677Reviewed-by: default avatarAlexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706704}
parent 750bd0b9
Hide whitespace changes
Inline Side-by-side
Showing with 52 additions and 5 deletions
third_party/blink/web_tests/TestExpectations
View file @ 02c36253
...@@ -2662,7 +2662,7 @@ crbug.com/626703 [ Win ] external/wpt/css/css-align/baseline-rules/grid-item-inp ...@@ -2662,7 +2662,7 @@ crbug.com/626703 [ Win ] external/wpt/css/css-align/baseline-rules/grid-item-inp
crbug.com/626703 [ Linux ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ] crbug.com/626703 [ Linux ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ]
crbug.com/626703 [ Mac ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ] crbug.com/626703 [ Mac ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ]
crbug.com/626703 [ Win ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ] crbug.com/626703 [ Win ] external/wpt/css/css-align/baseline-rules/grid-item-input-type-text.html [ Failure ]
crbug.com/626703 external/wpt/webxr/events_referenceSpace_reset.https.html [ Timeout ] crbug.com/626703 external/wpt/webxr/events_referenceSpace_reset_inline.https.html [ Timeout ]
crbug.com/626703 [ Linux ] external/wpt/clear-site-data/storage.https.html [ Timeout ] crbug.com/626703 [ Linux ] external/wpt/clear-site-data/storage.https.html [ Timeout ]
crbug.com/626703 [ Mac ] external/wpt/clear-site-data/storage.https.html [ Timeout ] crbug.com/626703 [ Mac ] external/wpt/clear-site-data/storage.https.html [ Timeout ]
crbug.com/626703 [ Win ] external/wpt/clear-site-data/storage.https.html [ Timeout ] crbug.com/626703 [ Win ] external/wpt/clear-site-data/storage.https.html [ Timeout ]
......
third_party/blink/web_tests/external/wpt/webxr/events_referenceSpace_reset_immersive.https.html 0 → 100644
View file @ 02c36253
<!DOCTYPE html>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src="resources/webxr_util.js"></script>
<script src="resources/webxr_test_constants.js"></script>
<canvas id="webgl-canvas"></canvas>
<script>
let immersiveTestName = "XRSession resetpose from a device properly fires off " +
"the right events for immersive sessions";
let watcherDone = new Event("watcherdone");
let fakeDeviceInitParams = TRACKED_IMMERSIVE_DEVICE;
let testFunction = function(session, fakeDeviceController, t) {
let resetPromise = session.requestReferenceSpace('local')
.then((refSpace) => {
let eventWatcher = new EventWatcher(
t, refSpace, ["reset", "watcherdone"]);
refSpace.addEventListener("reset", (event) => {
t.step(() => {
assert_equals(event.referenceSpace, refSpace);
// Also make sure the same objects are returned each time these
// attributes are accessed.
let eventRefSpace = event.referenceSpace;
let transform = event.transform;
assert_equals(eventRefSpace, event.referenceSpace,
"XRReferenceSpaceEvent.referenceSpace returns the same object.");
assert_equals(transform, event.transform,
"XRReferenceSpaceEvent.transform returns the same object.");
});
refSpace.dispatchEvent(watcherDone);
}, false);
return eventWatcher.wait_for(["reset", "watcherdone"]);
});
fakeDeviceController.simulateResetPose();
// The triggered resetPose event should arrive after the next Animation Frame
session.requestAnimationFrame(() => {});
return resetPromise;
};
xr_session_promise_test(
immersiveTestName, testFunction, fakeDeviceInitParams, 'immersive-vr');
</script>
third_party/blink/web_tests/external/wpt/webxr/events_referenceSpace_reset.https.html → third_party/blink/web_tests/external/wpt/webxr/events_referenceSpace_reset_inline.https.html
View file @ 02c36253
...@@ -6,8 +6,6 @@ ...@@ -6,8 +6,6 @@
<canvas id="webgl-canvas"></canvas> <canvas id="webgl-canvas"></canvas>
<script> <script>
let immersiveTestName = "XRSession resetpose from a device properly fires off " +
"the right events for immersive sessions";
let nonImmersiveTestName = "XRSession resetpose from a device properly fires off " + let nonImmersiveTestName = "XRSession resetpose from a device properly fires off " +
"the right events for non-immersive sessions"; "the right events for non-immersive sessions";
...@@ -47,8 +45,6 @@ let testFunction = function(session, fakeDeviceController, t) { ...@@ -47,8 +45,6 @@ let testFunction = function(session, fakeDeviceController, t) {
return resetPromise; return resetPromise;
}; };
xr_session_promise_test(
immersiveTestName, testFunction, fakeDeviceInitParams, 'immersive-vr');
xr_session_promise_test( xr_session_promise_test(
nonImmersiveTestName, testFunction, fakeDeviceInitParams, 'inline', { nonImmersiveTestName, testFunction, fakeDeviceInitParams, 'inline', {
requiredFeatures: ['local'], requiredFeatures: ['local'],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment