Commit 02c6ab4d authored by xhwang@chromium.org's avatar xhwang@chromium.org

Update the location of extract_actions.py in comments.

The file was moved in r191811.

BUG=none
TEST=none
R=isherman@chromium.org
TBR=achuith@chromium.org, joi@chromium.org

Review URL: https://codereview.chromium.org/100453005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238423 0039d316-1c4b-4281-b951-d872f2087c98
parent 7267ff86
...@@ -326,9 +326,9 @@ const Experiment::Choice kMapImageChoices[] = { ...@@ -326,9 +326,9 @@ const Experiment::Choice kMapImageChoices[] = {
// comment to the end of the feature name, like so: // comment to the end of the feature name, like so:
// "my-special-feature", // FLAGS:RECORD_UMA // "my-special-feature", // FLAGS:RECORD_UMA
// //
// After doing that, run //chrome/tools/extract_actions.py (see instructions at // After doing that, run //tools/metrics/actions/extract_actions.py (see
// the top of that file for details) to update the chromeactions.txt file, which // instructions at the top of that file for details) to update the
// will enable UMA to record your feature flag. // chromeactions.txt file, which will enable UMA to record your feature flag.
// //
// After your feature has shipped under a flag, you can locate the metrics under // After your feature has shipped under a flag, you can locate the metrics under
// the action name AboutFlags_internal-action-name. Actions are recorded once // the action name AboutFlags_internal-action-name. Actions are recorded once
......
...@@ -91,9 +91,9 @@ void SetupProgressiveScanFieldTrial() { ...@@ -91,9 +91,9 @@ void SetupProgressiveScanFieldTrial() {
// Write the group to the file to be read by ChromeOS. // Write the group to the file to be read by ChromeOS.
int size = static_cast<int>(group_char.length()); int size = static_cast<int>(group_char.length());
if (file_util::WriteFile(group_file_path, group_char.c_str(), size) == size) { if (file_util::WriteFile(group_file_path, group_char.c_str(), size) == size) {
LOG(INFO) << "Configured in group '" << trial->group_name() VLOG(1) << "Configured in group '" << trial->group_name()
<< "' ('" << group_char << "') for " << "' ('" << group_char << "') for "
<< name_of_experiment << " field trial"; << name_of_experiment << " field trial";
} else { } else {
LOG(ERROR) << "Couldn't write to " << group_file_path.value(); LOG(ERROR) << "Couldn't write to " << group_file_path.value();
} }
...@@ -110,8 +110,8 @@ ExternalMetrics::~ExternalMetrics() {} ...@@ -110,8 +110,8 @@ ExternalMetrics::~ExternalMetrics() {}
void ExternalMetrics::Start() { void ExternalMetrics::Start() {
// Register user actions external to the browser. // Register user actions external to the browser.
// chrome/tools/extract_actions.py won't understand these lines, so all of // tools/metrics/actions/extract_actions.py won't understand these lines, so
// these are explicitly added in that script. // all of these are explicitly added in that script.
// TODO(derat): We shouldn't need to verify actions before reporting them; // TODO(derat): We shouldn't need to verify actions before reporting them;
// remove all of this once http://crosbug.com/11125 is fixed. // remove all of this once http://crosbug.com/11125 is fixed.
valid_user_actions_.insert("Cryptohome.PKCS11InitFail"); valid_user_actions_.insert("Cryptohome.PKCS11InitFail");
......
...@@ -51,7 +51,7 @@ CONTENT_EXPORT void RecordAction(const UserMetricsAction& action); ...@@ -51,7 +51,7 @@ CONTENT_EXPORT void RecordAction(const UserMetricsAction& action);
// not automatically found by the action-processing scripts. It can be used // not automatically found by the action-processing scripts. It can be used
// when it's a pain to enumerate all possible actions, but if you use this // when it's a pain to enumerate all possible actions, but if you use this
// you need to also update the rules for extracting known actions in // you need to also update the rules for extracting known actions in
// chrome/tools/extract_actions.py. // tools/metrics/actions/extract_actions.py.
CONTENT_EXPORT void RecordComputedAction(const std::string& action); CONTENT_EXPORT void RecordComputedAction(const std::string& action);
// Called with the action string. // Called with the action string.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment