Commit 02d4be3f authored by Dmitry Gozman's avatar Dmitry Gozman Committed by Commit Bot

[DevTools] Do not assume we were attached to OOPIF

Bug: 836511
Change-Id: I9ac2c9613235758f47b7b44d9b5f8c46b5a35734
Reviewed-on: https://chromium-review.googlesource.com/1048843Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556979}
parent 3c79bfc0
...@@ -170,7 +170,10 @@ DevToolsAgentHost* TargetAutoAttacher::AutoAttachToFrame( ...@@ -170,7 +170,10 @@ DevToolsAgentHost* TargetAutoAttacher::AutoAttachToFrame(
DCHECK(old_cross_process); DCHECK(old_cross_process);
auto it = auto_attached_hosts_.find(agent_host); auto it = auto_attached_hosts_.find(agent_host);
DCHECK(it != auto_attached_hosts_.end()); // This should not happen in theory, but error pages are sometimes not
// picked up. See https://crbug.com/836511 and https://crbug.com/817881.
if (it == auto_attached_hosts_.end())
return nullptr;
auto_attached_hosts_.erase(it); auto_attached_hosts_.erase(it);
detach_callback_.Run(agent_host.get()); detach_callback_.Run(agent_host.get());
return nullptr; return nullptr;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment