Commit 02ec4e9c authored by Javier Ernesto Flores Robles's avatar Javier Ernesto Flores Robles Committed by Commit Bot

[iOS][MF] Make sure the gray line is hidden when appears

View was being hidden on prepare to reuse only, causing it to be shown
the first time the cell was used.

Bug: 845472, 911148
Change-Id: Ic59d5de5f476c7e499d40a244ef1291e4ccd3bfa
Reviewed-on: https://chromium-review.googlesource.com/c/1358447
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613128}
parent ed1c99d3
......@@ -89,7 +89,6 @@ static const CGFloat BottomBaseSystemSpacingMultiplier = 1.5;
[self.titleButton setTitleColor:UIColor.cr_manualFillTintColor
forState:UIControlStateNormal];
self.titleButton.enabled = YES;
self.grayLine.hidden = YES;
}
- (void)setUpWithTitle:(NSString*)title
......@@ -101,7 +100,7 @@ static const CGFloat BottomBaseSystemSpacingMultiplier = 1.5;
[self createView];
}
NSMutableArray<UIView*>* verticalLeadViews = [[NSMutableArray alloc] init];
self.grayLine.hidden = !showSeparator;
[self.titleButton setTitle:title forState:UIControlStateNormal];
self.titleButton.accessibilityIdentifier = accessibilityID;
......@@ -111,11 +110,9 @@ static const CGFloat BottomBaseSystemSpacingMultiplier = 1.5;
forState:UIControlStateNormal];
}
self.action = action;
[verticalLeadViews addObject:self.titleButton];
if (showSeparator) {
self.grayLine.hidden = NO;
}
NSMutableArray<UIView*>* verticalLeadViews = [[NSMutableArray alloc] init];
[verticalLeadViews addObject:self.titleButton];
self.verticalConstraints =
VerticalConstraintsSpacingForViewsInContainerWithMultipliers(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment