Commit 02ffeae9 authored by Sven Zheng's avatar Sven Zheng Committed by Chromium LUCI CQ

Lacros: is_cfi, use_thin_lto and use_cfi_cast default value update

Bug: 1157567
Change-Id: Icebc4367286fcb7372b9c6e7c8909b84d9dc9917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591487
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: default avatarHidehiko Abe <hidehiko@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#838197}
parent fbeb26e5
...@@ -69,7 +69,8 @@ declare_args() { ...@@ -69,7 +69,8 @@ declare_args() {
# Chrome's clang. crbug.com/1033839 # Chrome's clang. crbug.com/1033839
use_thin_lto = is_cfi || (is_official_build && use_thin_lto = is_cfi || (is_official_build &&
(target_os == "android" || (target_os == "android" ||
(target_os == "chromeos" && is_chromeos_device))) ((is_chromeos_ash || is_chromeos_lacros)
&& is_chromeos_device)))
# If true, use Goma for ThinLTO code generation where applicable. # If true, use Goma for ThinLTO code generation where applicable.
use_goma_thin_lto = false use_goma_thin_lto = false
......
...@@ -61,7 +61,7 @@ declare_args() { ...@@ -61,7 +61,7 @@ declare_args() {
is_cfi = is_cfi =
is_official_build && is_official_build &&
(((target_os == "linux" || is_chromeos_lacros) && target_cpu == "x64") || (((target_os == "linux" || is_chromeos_lacros) && target_cpu == "x64") ||
(target_os == "chromeos" && is_chromeos_device && !is_chromeos_lacros)) ((is_chromeos_ash || is_chromeos_lacros) && is_chromeos_device))
# Enable checks for indirect function calls via a function pointer. # Enable checks for indirect function calls via a function pointer.
# TODO(pcc): remove this when we're ready to add these checks by default. # TODO(pcc): remove this when we're ready to add these checks by default.
...@@ -123,7 +123,7 @@ declare_args() { ...@@ -123,7 +123,7 @@ declare_args() {
# Enable checks for bad casts: derived cast and unrelated cast. # Enable checks for bad casts: derived cast and unrelated cast.
# TODO(krasin): remove this, when we're ready to add these checks by default. # TODO(krasin): remove this, when we're ready to add these checks by default.
# https://crbug.com/626794 # https://crbug.com/626794
use_cfi_cast = is_cfi && target_os == "chromeos" use_cfi_cast = is_cfi && (is_chromeos_ash || is_chromeos_lacros)
} }
# Disable sanitizers for non-target toolchains. # Disable sanitizers for non-target toolchains.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment