Commit 030d74f4 authored by leon.han's avatar leon.han Committed by Commit bot

Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352

Review-Url: https://codereview.chromium.org/2568003002
Cr-Commit-Position: refs/heads/master@{#438002}
parent c3aaa23c
...@@ -13,7 +13,6 @@ ...@@ -13,7 +13,6 @@
#include "components/ui_devtools/Forward.h" #include "components/ui_devtools/Forward.h"
#include "components/ui_devtools/Protocol.h" #include "components/ui_devtools/Protocol.h"
#include "components/ui_devtools/devtools_client.h" #include "components/ui_devtools/devtools_client.h"
#include "components/ui_devtools/devtools_export.h"
#include "components/ui_devtools/string_util.h" #include "components/ui_devtools/string_util.h"
#include "net/server/http_server.h" #include "net/server/http_server.h"
...@@ -26,12 +25,12 @@ class UiDevToolsServer : public net::HttpServer::Delegate { ...@@ -26,12 +25,12 @@ class UiDevToolsServer : public net::HttpServer::Delegate {
// Returns an empty unique_ptr if ui devtools flag isn't enabled or if a // Returns an empty unique_ptr if ui devtools flag isn't enabled or if a
// server instance has already been created. // server instance has already been created.
static UI_DEVTOOLS_EXPORT std::unique_ptr<UiDevToolsServer> Create( static std::unique_ptr<UiDevToolsServer> Create(
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner); scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner);
// Returns a list of attached UiDevToolsClient name + URL // Returns a list of attached UiDevToolsClient name + URL
using NameUrlPair = std::pair<std::string, std::string>; using NameUrlPair = std::pair<std::string, std::string>;
static UI_DEVTOOLS_EXPORT std::vector<NameUrlPair> GetClientNamesAndUrls(); static std::vector<NameUrlPair> GetClientNamesAndUrls();
void AttachClient(std::unique_ptr<UiDevToolsClient> client); void AttachClient(std::unique_ptr<UiDevToolsClient> client);
void SendOverWebSocket(int connection_id, const String& message); void SendOverWebSocket(int connection_id, const String& message);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment