Commit 031776d9 authored by zerny@chromium.org's avatar zerny@chromium.org

Oilpan: Replace blink_gc_plugin_dump_graph with a more general blink_gc_plugin_flags GYP variable.

This allows developers to pass any combination of plugin flags
without modifying the existing GYP setup. For example,
GYP_DEFINES+="blink_gc_plugin_flags='dump-graph=1 warn-raw-ptr=1'"
will enable both graph dumps and raw-pointer warnings.

R=haraken@chromium.org
BUG=334149

Review URL: https://codereview.chromium.org/551343003

git-svn-id: svn://svn.chromium.org/blink/trunk@181734 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 7b78300c
...@@ -36,9 +36,8 @@ ...@@ -36,9 +36,8 @@
# If set to 1 (default) and using clang, the Blink GC plugin will check the # If set to 1 (default) and using clang, the Blink GC plugin will check the
# usage of the garbage-collection infrastructure during compilation. # usage of the garbage-collection infrastructure during compilation.
'blink_gc_plugin%': 1, 'blink_gc_plugin%': 1,
# If set to 1 together with blink_gc_plugin, the Blink GC plugin will dump # Additional flags for the Blink GC plugin.
# points-to graph files for each compilation unit. 'blink_gc_plugin_flags%': '',
'blink_gc_plugin_dump_graph%': 0,
# If set to 1, the Blink will use the base allocator instead of # If set to 1, the Blink will use the base allocator instead of
# PartitionAlloc. so that the top of stack-unwinding becomes the caller # PartitionAlloc. so that the top of stack-unwinding becomes the caller
# which requests memory allocation in blink. # which requests memory allocation in blink.
...@@ -103,9 +102,9 @@ ...@@ -103,9 +102,9 @@
}], }],
# Only enable the blink_gc_plugin when using clang and chrome plugins. # Only enable the blink_gc_plugin when using clang and chrome plugins.
['blink_gc_plugin==1 and clang==1 and clang_use_chrome_plugins==1', { ['blink_gc_plugin==1 and clang==1 and clang_use_chrome_plugins==1', {
'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.sh enable-oilpan=<(enable_oilpan) dump-graph=<(blink_gc_plugin_dump_graph))'], 'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.sh enable-oilpan=<(enable_oilpan) <(blink_gc_plugin_flags))'],
'xcode_settings': { 'xcode_settings': {
'OTHER_CFLAGS': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.sh enable-oilpan=<(enable_oilpan) dump-graph=<(blink_gc_plugin_dump_graph))'], 'OTHER_CFLAGS': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.sh enable-oilpan=<(enable_oilpan) <(blink_gc_plugin_flags))'],
}, },
}], }],
['blink_disable_partition_allocator==1', { ['blink_disable_partition_allocator==1', {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment