Commit 032f1acb authored by Wei-Yin Chen (陳威尹)'s avatar Wei-Yin Chen (陳威尹) Committed by Commit Bot

Clean up naming in PRESUBMIT_test.py

The class names should end with "Test", and the test* methods should
use relevant names.

Bug: None
Change-Id: I53ad14e3e19674f96218fcb9eb2d7646dedb1754
Reviewed-on: https://chromium-review.googlesource.com/1152116Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578801}
parent f0d7951f
...@@ -1030,7 +1030,7 @@ class AndroidDeprecatedTestAnnotationTest(unittest.TestCase): ...@@ -1030,7 +1030,7 @@ class AndroidDeprecatedTestAnnotationTest(unittest.TestCase):
'UsedDeprecatedSmokeAnnotation not found in errors') 'UsedDeprecatedSmokeAnnotation not found in errors')
class AndroidDeprecatedJUnitFrameworkTest(unittest.TestCase): class AndroidDeprecatedJUnitFrameworkTest(unittest.TestCase):
def testCheckAndroidTestAnnotationUsage(self): def testCheckAndroidTestJUnitFramework(self):
mock_input_api = MockInputApi() mock_input_api = MockInputApi()
mock_output_api = MockOutputApi() mock_output_api = MockOutputApi()
...@@ -1063,8 +1063,8 @@ class AndroidDeprecatedJUnitFrameworkTest(unittest.TestCase): ...@@ -1063,8 +1063,8 @@ class AndroidDeprecatedJUnitFrameworkTest(unittest.TestCase):
in msgs[0].items, in msgs[0].items,
'UsedDeprecatedJUnitAssert not found in errors') 'UsedDeprecatedJUnitAssert not found in errors')
class AndroidJUnitBaseClass(unittest.TestCase): class AndroidJUnitBaseClassTest(unittest.TestCase):
def testCheckAndroidTestAnnotationUsage(self): def testCheckAndroidTestJUnitBaseClass(self):
mock_input_api = MockInputApi() mock_input_api = MockInputApi()
mock_output_api = MockOutputApi() mock_output_api = MockOutputApi()
...@@ -1572,7 +1572,7 @@ class BannedFunctionCheckTest(unittest.TestCase): ...@@ -1572,7 +1572,7 @@ class BannedFunctionCheckTest(unittest.TestCase):
self.assertTrue('some/mac/file.mm' not in errors[0].message) self.assertTrue('some/mac/file.mm' not in errors[0].message)
class NoProductionCodeUsingTestOnlyFunctions(unittest.TestCase): class NoProductionCodeUsingTestOnlyFunctionsTest(unittest.TestCase):
def testTruePositives(self): def testTruePositives(self):
mock_input_api = MockInputApi() mock_input_api = MockInputApi()
mock_input_api.files = [ mock_input_api.files = [
...@@ -1605,7 +1605,7 @@ class NoProductionCodeUsingTestOnlyFunctions(unittest.TestCase): ...@@ -1605,7 +1605,7 @@ class NoProductionCodeUsingTestOnlyFunctions(unittest.TestCase):
self.assertEqual(0, len(results)) self.assertEqual(0, len(results))
class NoProductionJavaCodeUsingTestOnlyFunctions(unittest.TestCase): class NoProductionJavaCodeUsingTestOnlyFunctionsTest(unittest.TestCase):
def testTruePositives(self): def testTruePositives(self):
mock_input_api = MockInputApi() mock_input_api = MockInputApi()
mock_input_api.files = [ mock_input_api.files = [
...@@ -1652,7 +1652,7 @@ class NoProductionJavaCodeUsingTestOnlyFunctions(unittest.TestCase): ...@@ -1652,7 +1652,7 @@ class NoProductionJavaCodeUsingTestOnlyFunctions(unittest.TestCase):
self.assertEqual(0, len(results)) self.assertEqual(0, len(results))
class CheckUniquePtr(unittest.TestCase): class CheckUniquePtrTest(unittest.TestCase):
def testTruePositivesNullptr(self): def testTruePositivesNullptr(self):
mock_input_api = MockInputApi() mock_input_api = MockInputApi()
mock_input_api.files = [ mock_input_api.files = [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment