Skip to content

GitLab

T
tangled
Commit 0358579e authored by Gyuyoung Kim's avatar Gyuyoung Kim Committed by Commit Bot
Browse files
Options

[css-filters] Migrate remove-filter-repaint.html to WPT 

This CL migrates remove-filter-repaint[-expected].html
tests from css3/filters to external/wpt/css/filter-effects
with WPT styles, adding links to the relevant specs, and
test description.

Additionally, this test is renamed to
remove-filter-repaint[-ref].html to be align with
WPT naming style.

Bug: 1063749
Change-Id: I38aa8afc6ef821fc7f11211855e8043f39495e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143181Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#758651}
parent c21ee9b0
Hide whitespace changes
Inline Side-by-side
Showing with 62 additions and 65 deletions
third_party/blink/web_tests/css3/filters/remove-filter-repaint.html deleted 100644 → 0
View file @ c21ee9b0
<!DOCTYPE html>
<html>
<head>
<title>filter-bug</title>
<style>
.backdrop {
position: absolute;
top: 0;
left: 0;
height: 100px;
width: 100px;
background-color: silver;
}
.overlay {
position: absolute;
top: 50px;
left: 50px;
width: 400px;
height: 100px;
background: gray;
box-shadow: 0 0 4px black;
}
.play {
font-size: 36pt;
background-color: navy;
color: white;
}
.play.changed {
filter: drop-shadow(black 0 0 5px);
}
.composited {
will-change: transform;
}
</style>
<script>
if (window.testRunner)
testRunner.waitUntilDone();
function doTest()
{
requestAnimationFrame(function() {
document.getElementById('play').classList.remove('changed');
if (window.testRunner)
testRunner.notifyDone();
}, 0);
}
window.addEventListener('load', doTest, false);
</script>
</head>
<body>
<div class="composited backdrop"></div>
<div class="overlay">
<span id="play" class="play changed">this should be
visible</span>
</div>
</body>
</html>
third_party/blink/web_tests/css3/filters/remove-filter-repaint-expected.html → third_party/blink/web_tests/external/wpt/css/filter-effects/reference/remove-filter-repaint-ref.html
View file @ 0358579e
<!DOCTYPE html> <!DOCTYPE html>
<html> <html>
<head> <head>
<title>filter-bug</title> <title>CSS Filters: Repaint a compositing layer</title>
<style> <style>
.backdrop { .backdrop {
position: absolute; position: absolute;
...@@ -35,8 +35,7 @@ ...@@ -35,8 +35,7 @@
<body> <body>
<div class="composited backdrop"></div> <div class="composited backdrop"></div>
<div class="overlay"> <div class="overlay">
<span id="play" class="play changed">this should be <span id="play" class="play changed">this should be visible</span>
visible</span>
</div> </div>
</body> </body>
</html> </html>
third_party/blink/web_tests/external/wpt/css/filter-effects/remove-filter-repaint.html 0 → 100644
View file @ 0358579e
<!DOCTYPE html>
<html>
<head>
<title>CSS Filters: Repaint a compositing layer</title>
<link rel="author" title="Simon Fraser" href="mailto:simon.fraser@apple.com>">
<link rel="help" href="https://drafts.fxtf.org/filter-effects/#dropshadowEquivalent">
<link rel="issue" href="https://bugs.webkit.org/show_bug.cgi?id=120135">
<link rel="issue" href="https://chromiumcodereview.appspot.com/23526037">
<link rel="match" href="reference/remove-filter-repaint-ref.html">
<meta name="assert" content="This test ensures that we can repaint the compositing layer when removing a filter on an inline child of a compositing layer.">
<script src="/common/reftest-wait.js"></script>
<style>
.backdrop {
position: absolute;
top: 0;
left: 0;
height: 100px;
width: 100px;
background-color: silver;
}
.overlay {
position: absolute;
top: 50px;
left: 50px;
width: 400px;
height: 100px;
background: gray;
box-shadow: 0 0 4px black;
}
.play {
font-size: 36pt;
background-color: navy;
color: white;
}
.play.changed {
filter: drop-shadow(black 0 0 5px);
}
.composited {
will-change: transform;
}
</style>
<script>
function doTest() {
requestAnimationFrame(function() {
requestAnimationFrame(function() {
document.getElementById('play').classList.remove('changed');
takeScreenshot();
});
});
}
window.addEventListener('load', doTest, false);
</script>
</head>
<body>
<div class="composited backdrop"></div>
<div class="overlay">
<span id="play" class="play changed">this should be visible</span>
</div>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment