Add regression test for guest view name collision in extension

This tests that an extension background page is able to declare variables whose names are the same as guest view elements without the declarations being considered syntax errors. Bug: 1014385 Change-Id: I5ca92d739fe04fece2078f53e9f5eca4f73b040f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864407Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#712188}

Add regression test for guest view name collision in extension
This tests that an extension background page is able to declare variables whose names are the same as guest view elements without the declarations being considered syntax errors. Bug: 1014385 Change-Id: I5ca92d739fe04fece2078f53e9f5eca4f73b040f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864407Reviewed-by: James MacLean <wjmaclean@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#712188}
035e3b00 · Kevin McNee · Commit Bot · 32ad4bd0 · 035e3b00 · 035e3b00
Commit 035e3b00 authored Nov 04, 2019 by Kevin McNee Committed by Commit Bot Nov 04, 2019
5 changed files
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -4415,3 +4415,24 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, OpenAndCloseDevTools) {
      embedder, false /* is_docked */);
  DevToolsWindowTesting::CloseDevToolsWindowSync(devtools);
 }
+
+// Regression test for https://crbug.com/1014385
+// We load an extension whose background page attempts to declare variables with
+// names that are the same as guest view types. The declarations should not be
+// syntax errors.
+using GuestViewExtensionNameCollisionTest = extensions::ExtensionBrowserTest;
+IN_PROC_BROWSER_TEST_F(GuestViewExtensionNameCollisionTest,
+                       GuestViewNamesDoNotCollideWithExtensions) {
+  ExtensionTestMessageListener loaded_listener("LOADED", false);
+  const extensions::Extension* extension =
+      LoadExtension(test_data_dir_.AppendASCII(
+          "platform_apps/web_view/no_extension_name_collision"));
+  ASSERT_TRUE(loaded_listener.WaitUntilSatisfied());
+
+  const std::string script =
+      "window.domAutomationController.send("
+      "    window.testPassed ? 'PASSED' : 'FAILED');";
+  const std::string test_passed =
+      ExecuteScriptInBackgroundPage(extension->id(), script);
+  EXPECT_EQ("PASSED", test_passed);
+}
--- a/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/background.html
+++ b/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/background.html
+<!--
+ * Copyright 2019 The Chromium Authors. All rights reserved.  Use of this
+ * source code is governed by a BSD-style license that can be found in the
+ * LICENSE file.
+-->
+<html>
+<head>
+  <script src="start_test.js"></script>
+  <script src="background.js"></script>
+</head>
+<body>
+</body>
+</html>
--- a/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/background.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/background.js
+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Regression test for https://crbug.com/1014385
+// Since this is an extension's background page, the following lines should not
+// throw a syntax error due to redeclaration.
+const ExtensionOptions = {};
+const AppView = {};
+const WebView = {};
+window.testPassed = true;
--- a/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/manifest.json
+++ b/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/manifest.json
+{
+   "name": "no_extension_name_collision",
+   "description": "Test that an extension can use names also used by guest views without naming collisions",
+
+   "manifest_version": 2,
+   "version": "1",
+
+   "background": {
+      "page": "background.html"
+   },
+   "permissions": [ "background" ]
+}
--- a/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/start_test.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/no_extension_name_collision/start_test.js
+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// We need to signal the start of the test from a different file because when
+// the test fails, we have a syntax error in background.js.
+chrome.test.sendMessage('LOADED');