align extra bitmap padding in unit test to avoid crash
At head this test adds 2 extra bytes of padding to each row of an 8888 (4 byte per pixel) bitmap. This misaligns all the odd rows. Through some sort of combination of lack of testing and luck of code generation, eraseColor() is not crashing on Chromium's tree, but it's within its rights to do so. The attached bug shows such a crash on a 32-bit ARM build running on a Nexus5x. To fix this, I think we can just pad each row by 4 extra bytes. This keeps every row aligned, and I think the spirit of the test intact. Bug: chromium:779715 Change-Id: I58e98e9d7dfe55dbe3512d287158449e21e25d2d Reviewed-on: https://chromium-review.googlesource.com/883741Reviewed-by:Michael Wasserman <msw@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#531730}
Showing
Please register or sign in to comment