Commit 037434ae authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

Disable OSSettingsSmbTest.All for debug builds

This test is flaky on debug builds; mostly fails with timeouts.
For now, it's better to disable this test case on debug builds.
This is somewhat a common pattern among webui tests -- and I think
it's fine as long as it's tested on the release builds.

Bug: 968608
Test: none
Change-Id: I09b19f1e1854f9e5943b55b75e61abef777c493e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639143Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
Reviewed-by: default avatarJordy Greenblatt <jordynass@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665309}
parent 3d9faf5e
......@@ -59,6 +59,13 @@ var OSSettingsSmbPageTest = class extends OSSettingsBrowserTest {
}
};
TEST_F('OSSettingsSmbPageTest', 'All', function() {
// OSSettingsSmbPageTest.All is flaky on debug. See https://crbug.com/968608.
GEN('#if !defined(NDEBUG)');
GEN('#define MAYBE_All DISABLED_All');
GEN('#else');
GEN('#define MAYBE_All All');
GEN('#endif');
TEST_F('OSSettingsSmbPageTest', 'MAYBE_All', function() {
mocha.run();
});
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment