Commit 037ad63d authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Fix field trial testing config for PDFViewerUpdate.

"PDF" should be in uppercase.

The one test that failed as a result of this flag flip is
ExtensionApiTest.TemporaryAddressSpoof. Update the test with a different
click coordinate that is compatible with the flag on or off.

Bug: 1048812
Change-Id: I72d0ce0a39f0d0a1d465c307dafe71f15b84dec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499182Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Reviewed-by: default avatardpapad <dpapad@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821137}
parent a8fcc7e0
......@@ -2107,12 +2107,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TemporaryAddressSpoof) {
// the guest WebContents as there is no longer a BrowserPlugin involved.
web_contents_for_click = inner_web_contents[0];
// The actual PDF page coordinates that this click goes to is (346, 333),
// after several space transformations, not (400, 400). This clicks on a link
// to "http://www.facebook.com:83".
// (400, 300) in `web_contents_for_click` translates to a different coordinate
// in the PDF Viewer. The exact coordinate depends on the PDF Viewer's UI
// layout. In the test PDF embedded in pdf_extension_test.html, the entire PDF
// content area is a giant link to http://www.facebook.com:83. As long as this
// click hits that link target, it triggers the navigation required for test.
content::SimulateMouseClickAt(web_contents_for_click, 0,
blink::WebMouseEvent::Button::kLeft,
gfx::Point(400, 400));
gfx::Point(400, 300));
ASSERT_TRUE(navigation_manager.WaitForRequestStart());
......
......@@ -5098,6 +5098,24 @@
]
}
],
"PDFViewerUpdate": [
{
"platforms": [
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PDFViewerUpdate"
]
}
]
}
],
"PaintHoldingCrossOrigin": [
{
"platforms": [
......@@ -5408,24 +5426,6 @@
]
}
],
"PdfViewerUpdate": [
{
"platforms": [
"chromeos",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"PdfViewerUpdate"
]
}
]
}
],
"PerProcessReclaim": [
{
"platforms": [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment