Commit 038ac2ad authored by Ilia Samsonov's avatar Ilia Samsonov Committed by Commit Bot

Add prefix to empty param tests.

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=ericorth@chromium.org

Bug: 1023677
Change-Id: Ic527ff1a7cb4654e17df53ba36a3da314187de17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957495
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: default avatarEric Orth <ericorth@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726587}
parent 4c76ab02
......@@ -77,7 +77,7 @@ class ProxyResolvingClientSocketTest
const bool use_tls_;
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
INSTANTIATE_TEST_SUITE_P(All,
ProxyResolvingClientSocketTest,
::testing::Bool());
......@@ -817,7 +817,7 @@ const int kProxyTestMockErrors[] = {net::ERR_PROXY_CONNECTION_FAILED,
net::ERR_SSL_PROTOCOL_ERROR};
INSTANTIATE_TEST_SUITE_P(
/* no prefix */,
All,
ReconsiderProxyAfterErrorTest,
testing::Combine(testing::Bool(),
testing::Bool(),
......
......@@ -180,7 +180,7 @@ class ProxyResolvingSocketTest : public ProxyResolvingSocketTestBase,
DISALLOW_COPY_AND_ASSIGN(ProxyResolvingSocketTest);
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
INSTANTIATE_TEST_SUITE_P(All,
ProxyResolvingSocketTest,
::testing::Bool());
......
......@@ -2812,7 +2812,7 @@ TEST_P(SimpleURLLoaderTest, GetFinalURLAfterRedirect) {
}
INSTANTIATE_TEST_SUITE_P(
/* No prefix */,
All,
SimpleURLLoaderTest,
testing::Values(SimpleLoaderTestHelper::DownloadType::TO_STRING,
SimpleLoaderTestHelper::DownloadType::TO_FILE,
......
......@@ -138,7 +138,7 @@ class SocketDataPumpTest : public testing::Test,
DISALLOW_COPY_AND_ASSIGN(SocketDataPumpTest);
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
INSTANTIATE_TEST_SUITE_P(All,
SocketDataPumpTest,
testing::Values(net::SYNCHRONOUS, net::ASYNC));
......
......@@ -692,7 +692,7 @@ class TCPSocketWithMockSocketTest
net::MockClientSocketFactory mock_client_socket_factory_;
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
INSTANTIATE_TEST_SUITE_P(All,
TCPSocketWithMockSocketTest,
testing::Values(net::SYNCHRONOUS, net::ASYNC));
......
......@@ -875,7 +875,7 @@ TEST_P(TLSClientSocketTest, WriteErrorBeforeUpgradeToTLS) {
}
INSTANTIATE_TEST_SUITE_P(
/* no prefix */,
All,
TLSClientSocketTest,
::testing::Values(TLSClientSocketTestBase::kDirect,
TLSClientSocketTestBase::kProxyResolving));
......@@ -954,7 +954,7 @@ class TLSClientSocketIoModeTest : public TLSClientSocketTestBase,
DISALLOW_COPY_AND_ASSIGN(TLSClientSocketIoModeTest);
};
INSTANTIATE_TEST_SUITE_P(/* no prefix */,
INSTANTIATE_TEST_SUITE_P(All,
TLSClientSocketIoModeTest,
testing::Values(net::SYNCHRONOUS, net::ASYNC));
......@@ -1185,7 +1185,7 @@ TEST_P(TLSClientSocketTestWithEmbeddedTestServer, ServerCertError) {
}
INSTANTIATE_TEST_SUITE_P(
/* no prefix */,
All,
TLSClientSocketTestWithEmbeddedTestServer,
::testing::Values(TLSClientSocketTestBase::kDirect,
TLSClientSocketTestBase::kProxyResolving));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment