Commit 03a93948 authored by Sean Gilhuly's avatar Sean Gilhuly Committed by Commit Bot

Add diagnostic check in EvictSurfaces

There is a deserialization error in FrameSinkManager::EvictSurfaces() on
Android. Add a check to HostFrameSinkManager::EvictSurfaces() to try and
capture a stack trace before the IPC call.

Bug: 911308
Change-Id: I7c277a585cf42e51aaf103b5f005893818b3b245
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504293Reviewed-by: default avatarkylechar <kylechar@chromium.org>
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638139}
parent 1112fab3
...@@ -305,6 +305,10 @@ HostFrameSinkManager::CreateVideoCapturer() { ...@@ -305,6 +305,10 @@ HostFrameSinkManager::CreateVideoCapturer() {
void HostFrameSinkManager::EvictSurfaces( void HostFrameSinkManager::EvictSurfaces(
const std::vector<SurfaceId>& surface_ids) { const std::vector<SurfaceId>& surface_ids) {
// TODO(sgilhuly): Remove this check once crbug.com/911308 is fixed.
for (auto& surface_id : surface_ids) {
CHECK(surface_id.is_valid());
}
frame_sink_manager_->EvictSurfaces(surface_ids); frame_sink_manager_->EvictSurfaces(surface_ids);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment