Commit 03b2c573 authored by Eric Roman's avatar Eric Roman Committed by Commit Bot

Remove an unnecessary TODO.

Bug: 721403
Change-Id: I5f6cf64be0a85e3d5ef8bf88d8dda1deea924635
Reviewed-on: https://chromium-review.googlesource.com/c/1356941Reviewed-by: default avatarClark DuVall <cduvall@chromium.org>
Reviewed-by: default avatarrajendrant <rajendrant@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612907}
parent ec177868
...@@ -144,9 +144,6 @@ void DataReductionProxyURLLoaderThrottle::MarkProxiesAsBad( ...@@ -144,9 +144,6 @@ void DataReductionProxyURLLoaderThrottle::MarkProxiesAsBad(
for (const auto& proxy : bad_proxies) for (const auto& proxy : bad_proxies)
proxy_list.AddProxyServer(proxy); proxy_list.AddProxyServer(proxy);
// TODO(https://crbug.com/721403): Does this need to handle the case where
// |callback| is never invoked (which can happen on a connection error in
// |data_reduction_proxy_|).
auto callback = base::BindOnce( auto callback = base::BindOnce(
&DataReductionProxyURLLoaderThrottle::OnMarkProxiesAsBadComplete, &DataReductionProxyURLLoaderThrottle::OnMarkProxiesAsBadComplete,
base::Unretained(this)); base::Unretained(this));
......
...@@ -40,6 +40,9 @@ void DataReductionProxyThrottleManager::MarkProxiesAsBad( ...@@ -40,6 +40,9 @@ void DataReductionProxyThrottleManager::MarkProxiesAsBad(
base::TimeDelta bypass_duration, base::TimeDelta bypass_duration,
const net::ProxyList& bad_proxies, const net::ProxyList& bad_proxies,
mojom::DataReductionProxy::MarkProxiesAsBadCallback callback) { mojom::DataReductionProxy::MarkProxiesAsBadCallback callback) {
// There is no need to handle the case where |callback| is never invoked
// (possible on connection error). That would imply disconnection from the
// browser, which is not recoverable.
data_reduction_proxy_->MarkProxiesAsBad(bypass_duration, bad_proxies, data_reduction_proxy_->MarkProxiesAsBad(bypass_duration, bad_proxies,
std::move(callback)); std::move(callback));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment