cros_healthd: Add GatewayCanBePinged routine

Add the GatewayCanBePinged routine to the ServiceConnection.

BUG=chromium:956783
TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.*
2) Applied GatewayCanBePinged changes and successfully ran the
GatewayCanBePinged routine on a DUT (verified using cros-health-tool diag
--action=run_routine --routine=gateway_can_be_pinged).

Change-Id: I942ead41313756f84a9b717809390809f6f331f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344648Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Oleh Lamzin <lamzin@google.com>
Commit-Queue: Kartik Hegde <khegde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816787}

chrome/browser/chromeos/policy/remote_commands/device_command_run_routine_job.cc

@@ -512,6 +512,15 @@ void DeviceCommandRunRoutineJob::RunImpl(CallbackWithResult succeeded_callback,
               std::move(failed_callback)));
       break;
     }
+    case chromeos::cros_healthd::mojom::DiagnosticRoutineEnum::
+        kGatewayCanBePinged: {
+      chromeos::cros_healthd::ServiceConnection::GetInstance()
+          ->RunGatewayCanBePingedRoutine(base::BindOnce(
+              &DeviceCommandRunRoutineJob::OnCrosHealthdResponseReceived,
+              weak_ptr_factory_.GetWeakPtr(), std::move(succeeded_callback),
+              std::move(failed_callback)));
+      break;
+    }
   }
 }
 

chromeos/dbus/cros_healthd/fake_cros_healthd_service.cc

@@ -217,6 +217,11 @@ void FakeCrosHealthdService::RunSignalStrengthRoutine(
   std::move(callback).Run(run_routine_response_.Clone());
 }
 
+void FakeCrosHealthdService::RunGatewayCanBePingedRoutine(
+    RunGatewayCanBePingedRoutineCallback callback) {
+  std::move(callback).Run(run_routine_response_.Clone());
+}
+
 void FakeCrosHealthdService::AddBluetoothObserver(
     mojom::CrosHealthdBluetoothObserverPtr observer) {
   bluetooth_observers_.Add(observer.PassInterface());

chromeos/dbus/cros_healthd/fake_cros_healthd_service.h

@@ -102,6 +102,8 @@ class FakeCrosHealthdService final
       RunLanConnectivityRoutineCallback callback) override;
   void RunSignalStrengthRoutine(
       RunSignalStrengthRoutineCallback callback) override;
+  void RunGatewayCanBePingedRoutine(
+      RunGatewayCanBePingedRoutineCallback callback) override;
 
   // CrosHealthdEventService overrides:
   void AddBluetoothObserver(

chromeos/services/cros_healthd/public/cpp/service_connection.cc

@@ -110,6 +110,9 @@ class ServiceConnectionImpl : public ServiceConnection {
   void RunSignalStrengthRoutine(
       mojom::CrosHealthdDiagnosticsService::RunSignalStrengthRoutineCallback
           callback) override;
+  void RunGatewayCanBePingedRoutine(
+      mojom::CrosHealthdDiagnosticsService::RunGatewayCanBePingedRoutineCallback
+          callback) override;
   void AddBluetoothObserver(
       mojo::PendingRemote<mojom::CrosHealthdBluetoothObserver> pending_observer)
       override;
@@ -377,6 +380,15 @@ void ServiceConnectionImpl::RunSignalStrengthRoutine(
       std::move(callback));
 }
 
+void ServiceConnectionImpl::RunGatewayCanBePingedRoutine(
+    mojom::CrosHealthdDiagnosticsService::RunGatewayCanBePingedRoutineCallback
+        callback) {
+  DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
+  BindCrosHealthdDiagnosticsServiceIfNeeded();
+  cros_healthd_diagnostics_service_->RunGatewayCanBePingedRoutine(
+      std::move(callback));
+}
+
 void ServiceConnectionImpl::AddBluetoothObserver(
     mojo::PendingRemote<mojom::CrosHealthdBluetoothObserver> pending_observer) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);

chromeos/services/cros_healthd/public/cpp/service_connection.h

@@ -186,13 +186,20 @@ class ServiceConnection {
       mojom::CrosHealthdDiagnosticsService::RunLanConnectivityRoutineCallback
           callback) = 0;
 
-  // Requests that cros_healthd runs the lan connectivity routine. See
+  // Requests that cros_healthd runs the signal strength routine. See
   // src/chromeos/service/cros_healthd/public/mojom/cros_healthd.mojom for
   // details.
   virtual void RunSignalStrengthRoutine(
       mojom::CrosHealthdDiagnosticsService::RunSignalStrengthRoutineCallback
           callback) = 0;
 
+  // Requests that cros_healthd runs the gateway can be pinged routine. See
+  // src/chromeos/service/cros_healthd/public/mojom/cros_healthd.mojom for
+  // details.
+  virtual void RunGatewayCanBePingedRoutine(
+      mojom::CrosHealthdDiagnosticsService::RunGatewayCanBePingedRoutineCallback
+          callback) = 0;
+
   // Subscribes to cros_healthd's Bluetooth-related events. See
   // src/chromeos/services/cros_healthd/public/mojom/cros_healthd.mojom for
   // details.

chromeos/services/cros_healthd/public/cpp/service_connection_unittest.cc

@@ -536,8 +536,8 @@ TEST_F(CrosHealthdServiceConnectionTest, RunLanConnectivityRoutine) {
   run_loop.Run();
 }
 
+// Test that we can run the signal strength routine.
 TEST_F(CrosHealthdServiceConnectionTest, RunSignalStrengthRoutine) {
-  // Test that we can run the signal strength routine.
   auto response = MakeRunRoutineResponse();
   FakeCrosHealthdClient::Get()->SetRunRoutineResponseForTesting(response);
   base::RunLoop run_loop;
@@ -549,6 +549,19 @@ TEST_F(CrosHealthdServiceConnectionTest, RunSignalStrengthRoutine) {
   run_loop.Run();
 }
 
+// Test that we can run the gateway can be pinged routine.
+TEST_F(CrosHealthdServiceConnectionTest, RunGatewayCanBePingedRoutine) {
+  auto response = MakeRunRoutineResponse();
+  FakeCrosHealthdClient::Get()->SetRunRoutineResponseForTesting(response);
+  base::RunLoop run_loop;
+  ServiceConnection::GetInstance()->RunGatewayCanBePingedRoutine(
+      base::BindLambdaForTesting([&](mojom::RunRoutineResponsePtr response) {
+        EXPECT_EQ(response, MakeRunRoutineResponse());
+        run_loop.Quit();
+      }));
+  run_loop.Run();
+}
+
 // Test that we can add a Bluetooth observer.
 TEST_F(CrosHealthdServiceConnectionTest, AddBluetoothObserver) {
   MockCrosHealthdBluetoothObserver observer;

chromeos/services/cros_healthd/public/mojom/cros_healthd.mojom

@@ -326,6 +326,16 @@ interface CrosHealthdDiagnosticsService {
   // * |response| - contains a unique identifier and status for the created
   //                routine.
   RunSignalStrengthRoutine() => (RunRoutineResponse response);
+
+  // Requests that the GatewayCanBePinged routine is created and started on the
+  // platform. This routine checks whether the gateway of connected networks is
+  // pingable. This routine is only available if GetAvailableRoutines returned
+  // kGatewayCanBePinged.
+  //
+  // The response:
+  // * |response| - contains a unique identifier and status for the created
+  //                routine.
+  RunGatewayCanBePingedRoutine() => (RunRoutineResponse response);
 };
 
 // Event interface exposed by the cros_healthd daemon.

chromeos/services/cros_healthd/public/mojom/cros_healthd_diagnostics.mojom

@@ -33,6 +33,7 @@ enum DiagnosticRoutineEnum {
   kMemory = 14,
   kLanConnectivity = 15,
   kSignalStrength = 16,
+  kGatewayCanBePinged = 17,
 };
 
 // Enumeration of the possible DiskRead routine's command type