[Cronet] Adjust some tests to run on fast devices/emulators.

Some devices/emulators run quickly so requests take less than 1ms,
which causes some test failures.  Fix them using MetricsTestUtil.assertAfter()
and also clean up copies of that code.

Bug: 751184
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icdce80479a887276b8921b4168a96c65b12d0143
Reviewed-on: https://chromium-review.googlesource.com/596073
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491076}

components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

@@ -1240,8 +1240,7 @@ public class BidirectionalStreamTest extends CronetTestBase {
             MetricsTestUtil.assertAfter(metrics.getRequestStart(), startTime);
             assertNotNull(metrics.getRequestEnd());
             MetricsTestUtil.assertAfter(endTime, metrics.getRequestEnd());
-            // Entire request should take more than 0 ms
-            assertTrue(metrics.getRequestEnd().getTime() - metrics.getRequestStart().getTime() > 0);
+            MetricsTestUtil.assertAfter(metrics.getRequestEnd(), metrics.getRequestStart());
         }
         assertEquals(expectError, callback.mError != null);
         assertEquals(expectError, callback.mOnErrorCalled);

components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java

@@ -112,8 +112,7 @@ public class MetricsTestUtil {
         assertAfter(metrics.getResponseStart(), startTime);
         assertNotNull(metrics.getRequestEnd());
         assertAfter(endTime, metrics.getRequestEnd());
-        // Entire request should take more than 0 ms
-        assertTrue(metrics.getRequestEnd().getTime() - metrics.getRequestStart().getTime() > 0);
+        assertAfter(metrics.getRequestEnd(), metrics.getRequestStart());
     }
 
     /**

components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

@@ -234,17 +234,14 @@ public class RequestFinishedInfoTest extends CronetTestBase {
 
         // Check the timing metrics
         assertNotNull(metrics.getRequestStart());
-        assertTrue(metrics.getRequestStart().after(startTime)
-                || metrics.getRequestStart().equals(startTime));
+        MetricsTestUtil.assertAfter(metrics.getRequestStart(), startTime);
         MetricsTestUtil.checkNoConnectTiming(metrics);
         assertNull(metrics.getSendingStart());
         assertNull(metrics.getSendingEnd());
         assertNull(metrics.getResponseStart());
         assertNotNull(metrics.getRequestEnd());
-        assertTrue(
-                metrics.getRequestEnd().before(endTime) || metrics.getRequestEnd().equals(endTime));
-        // Entire request should take more than 0 ms
-        assertTrue(metrics.getRequestEnd().getTime() - metrics.getRequestStart().getTime() > 0);
+        MetricsTestUtil.assertAfter(endTime, metrics.getRequestEnd());
+        MetricsTestUtil.assertAfter(metrics.getRequestEnd(), metrics.getRequestStart());
         assertTrue(metrics.getSentByteCount() == 0);
         assertTrue(metrics.getReceivedByteCount() == 0);
         mTestFramework.mCronetEngine.shutdown();